Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support webpush API pings #55

Closed
pjenvey opened this issue Aug 6, 2018 · 0 comments
Closed

Support webpush API pings #55

pjenvey opened this issue Aug 6, 2018 · 0 comments
Assignees
@pjenvey
Labels
enhancement New feature or request p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Aug 6, 2018

We only support emitting websocket level ping frames. Clients also ping us with "older" style webpush API pings (empty json dicts "{}"), which they expect a response to.
@pjenvey pjenvey added bug Something isn't working p1 labels Aug 6, 2018
@pjenvey pjenvey self-assigned this Aug 6, 2018
@pjenvey pjenvey added enhancement New feature or request and removed bug Something isn't working labels Aug 6, 2018
pjenvey added a commit that referenced this issue Aug 6, 2018
@pjenvey
feat: support webpush API pings
a6acb9d 
Closes #55
pjenvey added a commit that referenced this issue Aug 6, 2018
@pjenvey
feat: support webpush API pings
491ea7b 
Closes #55
pjenvey added a commit that referenced this issue Aug 6, 2018
@pjenvey
feat: support webpush API pings
b93d37f 
Closes #55
@pjenvey pjenvey mentioned this issue Aug 6, 2018
Merged
pjenvey added a commit that referenced this issue Aug 6, 2018
@pjenvey
feat: support webpush API pings
2366efe 
Closes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
enhancement New feature or request p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @jrconlin