-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timer/histogram metrics #41
Comments
#42 switched to histogram yet we continue to not see either type show up on datadog |
The difference w/ dogstatsd is it allows overriding the datadog API host field via a tag: https://help.datadoghq.com/hc/en-us/articles/218349043-How-to-remove-the-host-tag-when-submitting-metrics-via-dogstatsD We include a host tag w/ the lifespan metric. In rust the value's the node's internal IP address. It looks like this causes other tags (most importantly 'language:rust' and 'env:prod') to become disassociated with this overridden host (the metrics are there under these overriden raw IPs host) Python autopush specifies the Host header from the request as this value instead, always something like "push.services.mozilla.com". The python datadog lib does something different here, according to the datadog ui it seems to duplicate the metrics for both the host tag we specify and its regular host value (ec2 instance id). Long story short: we shouldn't include a host tag in either impl., "push.services.mozilla.com" isn't a useful data point. Nor is it useful in our Session INFO log. The MozLogs format includes a Hostname field anyway (exact value of datadog's) |
the tag overwrites datadog's API host field. it isn't a useful value for metrics or logs anyway Closes #41
autopush-rs's metrics go through dogstatsd vs the direct datadog HTTP API like autopush-py.
For whatever reason:
Even though
Timers, which exist in StatsD, are a sub-set of histograms in DogStatsD.
I'm not sure why dogstatsd doesn't handle timers for us (I imagine that's what the python datadog is doing for us under the covers/via the HTTP API), so we'll need to switch to the histogram type ourselves
The text was updated successfully, but these errors were encountered: