Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric notification drops #33

Closed
bbangert opened this issue Jul 13, 2018 · 0 comments
Closed

Metric notification drops #33

bbangert opened this issue Jul 13, 2018 · 0 comments
Assignees
@pjenvey
Labels
enhancement New feature or request p1

Comments

@bbangert
Copy link
Member

The dynamodb notification loading has a few spots where messages will be dropped silently that fail deserialization. We should do basic metric counters on these just so that we understand how frequently it happens and whether we need more detailed logging of these occurrences.
@bbangert bbangert added enhancement New feature or request p1 labels Jul 13, 2018
@pjenvey pjenvey self-assigned this Jul 16, 2018
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
refactor: push table names down into DynamoStorage
e4fd231 
to avoid passing them around everywhere (eventually we'll move
message_month as well we're fully migrated)

Issue #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
5907c6e 
Closes #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
84f1a6a 
Closes #33
@pjenvey pjenvey mentioned this issue Jul 20, 2018
Merged
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
refactor: push table names down into DynamoStorage
197ecf5 
to avoid passing them around everywhere (eventually we'll move
message_month too when we're fully migrated)

Issue #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
ad9aac7 
Closes #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
refactor: push table names down into DynamoStorage
d9d940a 
to avoid passing them around everywhere

Issue #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
ed16b64 
Closes #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
refactor: push table names down into DynamoStorage
43c40fd 
to avoid passing them around everywhere

Issue #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
7ef1594 
Closes #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
refactor: push table names down into DynamoStorage
750c00f 
to avoid passing them around everywhere

Issue #33
pjenvey added a commit that referenced this issue Jul 20, 2018
@pjenvey
feat: emit metrics for any failed notif conversions
4a50700 
Closes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
enhancement New feature or request p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert