Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display erroneous app_id in error message #302

Closed
jrconlin opened this issue Apr 20, 2022 · 0 comments · Fixed by #303
Closed

Display erroneous app_id in error message #302

jrconlin opened this issue Apr 20, 2022 · 0 comments · Fixed by #303
Assignees

Comments

@jrconlin
Copy link
Member

While deploying the autopush-endpoint to canary we saw an usually high number of No app ID found for user errors. It's not a 100% failure rate, however, as about 50% of the traffic goes through without a hitch.

We should record the "invalid" app-id as part of the the sentry error to determine if this is a string formatting error or some other bit of strangeness.

@jrconlin jrconlin self-assigned this Apr 20, 2022
jrconlin added a commit that referenced this issue Apr 20, 2022
This patch does two things in order to determine the spike in `InvalidAppId` messages:
1) Add the sent app_id to the InvalidAppId error message
2) strip quotes from the app_id (in case this is a json string
transposition error.)

Closes #302
jrconlin added a commit that referenced this issue May 4, 2022
* bug: add app_id to error message

This patch addresses the spike in `InvalidAppId` messages:
* Add the sent app_id to the InvalidAppId error message
* Add minimal handling of GCM data sends. This needs to be tested on stage
(if possible. It's no longer possible to create GCM tokens to validate).
* Realized that autoendpoint was not reading credentials from files.
  This is different behavior from the python version and SRE would
  appreciate the option.


Note that this overloads "FCM" settings. See
router::fcm::settings::FcmSettings for details.

Closes #CONSVC-1765
Closes #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant