Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move forked "a2" dependency into mozilla-services org #236

Closed
tublitzed opened this issue Nov 16, 2020 · 5 comments · Fixed by #245 or #253
Closed

Move forked "a2" dependency into mozilla-services org #236

tublitzed opened this issue Nov 16, 2020 · 5 comments · Fixed by #245 or #253
Assignees
Labels
2 Estimate - Small

Comments

@tublitzed
Copy link
Contributor

Following best practices to not tie production code to our personal repos, let's move this dep out of a personal repo and into the mozilla-services org before we deploy this to prod.

@AzureMarker
Copy link
Contributor

Let me know if you need any help from me.

@jrconlin jrconlin added the 2 Estimate - Small label Nov 17, 2020
@jrconlin jrconlin self-assigned this Dec 7, 2020
jrconlin added a commit that referenced this issue Dec 7, 2020
There has been no action on reown-com/a2#49 since
Aug 12 2020. Using a moz controlled branch for now.

Closes #236
@jrconlin
Copy link
Member

@tublitzed
Copy link
Contributor Author

@jrconlin
Copy link
Member

We may want to consider either owing a specific fork of this library, or replacing it with a more actively supported library, since the original library seems to be abandoned.

@tublitzed
Copy link
Contributor Author

Yup - worth looking at for sure. In the meantime, can we scope this ticket to simply replacing the link to a personal repo with something that we own? After that, we can look at replacing the lib separately.

jrconlin added a commit that referenced this issue Dec 15, 2020
* chore: move a2 under mozilla-services

There has been no action on reown-com/a2#49 since
Aug 12 2020. Using a moz controlled branch for now.

Closes #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Estimate - Small
Projects
None yet
3 participants