Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up padding and quotes in headers #192

Closed
jrconlin opened this issue Jul 20, 2020 · 1 comment · Fixed by #200 or #231
Closed

Clean up padding and quotes in headers #192

jrconlin opened this issue Jul 20, 2020 · 1 comment · Fixed by #200 or #231
Assignees
@AzureMarker
Labels
3 Estimate - Small...ish

Comments

@jrconlin
Copy link
Member

This duplicates an issue for autopush

Client reports issues with quotes and padding appearing in values passed from Encryption and Crypto-Key headers.

These are legacy "aesgcm" encryption formats that are still in use. Server should probably clean these values up (remove quotes and padding) before relaying.

Client may also take steps to resolve this issue.

image
@jrconlin jrconlin added the 3 Estimate - Small...ish label Jul 20, 2020
@jrconlin
Copy link
Member Author

see also: mozilla/application-services#3365

@AzureMarker AzureMarker assigned AzureMarker and unassigned jrconlin Jul 23, 2020
@AzureMarker AzureMarker mentioned this issue Jul 23, 2020
Merged
AzureMarker added a commit that referenced this issue Jul 27, 2020
@AzureMarker
fix: Strip padding and double quotes from encryption and crypto-key h…
e20fc6a 
…eaders (#200)

* Strip padding and double quotes from encryption and crypto-key headers

The regex is a little more complicated than the Python autopush version
because Rust's regex library does not support look-ahead, for
performance reasons.

* Improve strip_headers test

Closes #192
This was referenced Oct 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzureMarker AzureMarker

Labels
3 Estimate - Small...ish
Projects
None yet
Milestone
No milestone
2 participants
@jrconlin @AzureMarker