Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoendpoint] Support unregister user endpoint #179

Closed
AzureMarker opened this issue Jul 10, 2020 · 2 comments · Fixed by #195 or #231
Closed

[autoendpoint] Support unregister user endpoint #179

AzureMarker opened this issue Jul 10, 2020 · 2 comments · Fixed by #195 or #231
Assignees
Labels
2 Estimate - Small

Comments

@AzureMarker
Copy link
Contributor

AzureMarker commented Jul 10, 2020

Endpoint: DELETE /v1/{type}/{app_id}/registration/{uaid}
Documentation: https://autopush.readthedocs.io/en/latest/http.html#unregister-uaid-and-all-associated-channelid-subscriptions

Deletes the user and all channels.

Questions:

@AzureMarker AzureMarker added the 2 Estimate - Small label Jul 10, 2020
@AzureMarker AzureMarker added this to the Autoendpoint Rust Server milestone Jul 10, 2020
@AzureMarker AzureMarker self-assigned this Jul 10, 2020
@jrconlin
Copy link
Member

A: Yes. once a user is deleted, all data associated with the user should also be deleted.

@AzureMarker
Copy link
Contributor Author

AzureMarker commented Jul 21, 2020

It turns out that in order to delete all of the user's rows in the message table, we would need to scan for them and batch delete them (due to the Hash + Range key):
https://stackoverflow.com/questions/34259358/dynamodb-delete-all-items-having-same-hash-key

The Python code simply deletes the row in the router table (not touching the message table). Should we continue to use this behavior or follow the suggestion from the StackOverflow post?

@AzureMarker AzureMarker linked a pull request Jul 21, 2020 that will close this issue
AzureMarker added a commit that referenced this issue Jul 28, 2020
This was referenced Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment