Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoendpoint] Add errno values to errors and improve specificity of errors #159

Closed
AzureMarker opened this issue Jun 18, 2020 · 1 comment · Fixed by #170 or #231
Closed

[autoendpoint] Add errno values to errors and improve specificity of errors #159

AzureMarker opened this issue Jun 18, 2020 · 1 comment · Fixed by #170 or #231
Assignees
@AzureMarker
Labels
2 Estimate - Small
Milestone
Autoendpoint Rust...

Comments

@AzureMarker
Copy link
Contributor

Autoendpoint should emit detailed errors with associated error numbers and a link to http://autopush.readthedocs.io/en/latest/http.html#error-codes.

Currently, the errors are relatively detailed but lack error numbers and do not fully conform to the expected HTTP codes.

This work is more about polish, and it should probably happen after the major autoendpoint features are implemented.
@AzureMarker AzureMarker added the 2 Estimate - Small label Jun 18, 2020
@AzureMarker AzureMarker added this to the Autoendpoint Rust Server milestone Jun 18, 2020
@AzureMarker AzureMarker mentioned this issue Jun 24, 2020
Merged
@AzureMarker
Copy link
Contributor Author

Moving to in-progress, since it may be easier to add errno values as the features are implemented instead of going back to add them in.

@AzureMarker AzureMarker self-assigned this Jun 29, 2020
@AzureMarker AzureMarker mentioned this issue Jun 29, 2020
Merged
AzureMarker added a commit that referenced this issue Jul 13, 2020
@AzureMarker
feat: Return detailed autoendpoint errors (#170)
91d483a 
* Return an option in get_user to better handle the missing user case

* Add errno values for error kinds

* Add ApiErrorKind::errno

* Use the original error schema and return detailed error responses

Closes #159
This was referenced Oct 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzureMarker AzureMarker

Labels
2 Estimate - Small
Projects
None yet
Milestone
Autoendpoint Rust Server
1 participant
@AzureMarker