Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure log output is reasonable #117

Closed
pjenvey opened this issue Sep 27, 2019 · 0 comments · Fixed by #130
Closed

Ensure log output is reasonable #117

pjenvey opened this issue Sep 27, 2019 · 0 comments · Fixed by #130
Assignees
@pjenvey
Labels
5 Estimate - Medium p2

Comments

@pjenvey
Copy link
Member

pjenvey commented Sep 27, 2019

Our integration tests run autopush-rs, then fire off test_integration.py against it.

Let's add a check to test_integration ensuring autopush-rs's log output is reasonable: that it's not logging an excessive amount of statements during the test run. It should log probably less than a few lines during the test run (this might depend on whether it was built in debug vs release mode).

This would act as a fail-safe for the recent issue where the log trace level was mistakenly enabled.
@pjenvey pjenvey added the p2 label Sep 27, 2019
@tublitzed tublitzed mentioned this issue Oct 29, 2019
Closed
@tublitzed tublitzed added the 5 Estimate - Medium label Feb 4, 2020
pjenvey added a commit that referenced this issue Feb 14, 2020
@pjenvey
test: ensure sane logging levels
d6beb4c 
in --release mode fail tests w/ excessive logging levels (unless
explicitly stated w/ @max_logs)

Closes #117
pjenvey added a commit that referenced this issue Feb 14, 2020
@pjenvey
test: ensure sane logging levels
6376c58 
in --release mode fail tests w/ excessive logging levels (unless
explicitly stated w/ @max_logs)

Closes #117
@pjenvey pjenvey mentioned this issue Feb 14, 2020
Merged
pjenvey added a commit that referenced this issue Feb 18, 2020
@pjenvey
test: ensure sane logging levels
9b43321 
in --release mode fail tests w/ excessive logging levels (unless
explicitly stated w/ @max_logs)

and fix the Queue import now that python-future is no longer a
dependency

Closes #117
pjenvey added a commit that referenced this issue Feb 19, 2020
@pjenvey
test: ensure sane logging levels
1807710 
in --release mode fail tests w/ excessive logging levels (unless
explicitly stated w/ @max_logs)

- fix the Queue import now that python-future is no longer a
dependency
- update http per RUSTSEC-2019-0033 + 0034

Closes #117
pjenvey added a commit that referenced this issue Feb 19, 2020
@pjenvey
test: ensure sane logging levels
e68a060 
in --release mode fail tests w/ excessive logging levels (unless
explicitly stated w/ @max_logs)

- fix the Queue import now that python-future is no longer a
dependency
- update http per RUSTSEC-2019-0033 + 0034

Closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
5 Estimate - Medium p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: ensure sane logging levels mozilla-services/autopush-rs
2 participants
@pjenvey @tublitzed