Create extractor/ validators for autoendpoint API methods #103
Comments
AzureMarker
added a commit
that referenced
this issue
Jun 12, 2020
* Add FromRequest impl for Metrics * Organize routes and add the rest of the health checks * Edit the /__lbheartbeat__ route to be a little clearer * Add a no-op webpush route * Add basic webpush extraction structs * Impl FromRequest for TokenInfo * Translate wip FromRequest impl for Subscription from Python validator Needs the meat of the validation + refactoring. Also unsure if the crypto_keys config is correct, as the Python version enforces brackets, even in env variables. * Extract extractors to new module and add some docs Pun fully intended. * Add some more docs and refactoring to Subscription FromRequest impl * Add a WebPushHeaders extractor and header utilities * Add validation to WebPushHeaders * Impl FromRequest for Notification Based on the Python validator/extractor. Kind of annoying that we have to `take` the payload because GATs isn't stable... Hopefully no one else needs it! * Fix incorrect call to get server state * Add extractors to webpush_route * Fix errors after rebase * Add error for invalid token * Make the subscription public key optional v1 may not have a public key * Suppress unused variable / mutability lint warnings * Be more explicit about what extractors need the payload * Add a PayloadError error kind to remove a TODO Related to #103 (needs more work before it can be closed).
This was referenced Jun 12, 2020
AzureMarker
added a commit
that referenced
this issue
Jun 26, 2020
* Use an enum for API version and add VapidHeaderWithKey * Perform expiration time validation on the JWT * Perform JWT claims extraction * Use the jsonwebtoken library for JWT validation * Add back VapidError::FutureExpirationToken and associated check The JWT library doesn't handle this error. * Record another metric for vapid version * Simplify handling of VAPID v2 in extract_public_key Closes #103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
autoendpoint has a fairly large amount of validation required, this should all be ported in as actix extractors and custom validation logic as needed (syncstorage-rs has some examples of this).
Depends on #102.
The text was updated successfully, but these errors were encountered: