Skip to content

Commit

Permalink
chore: added missing use_oidc gcr-auth param (#761)
Browse files Browse the repository at this point in the history
This value was defaulting to `false`, causing the orb to expect a
service account key to be present.

---------

Co-authored-by: JR Conlin <[email protected]>
  • Loading branch information
emaydeck-mozilla and jrconlin authored Sep 4, 2024
1 parent bd1ca69 commit b3740a8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,14 @@ jobs:
type: string
default: us-docker.pkg.dev
steps:
# gcr-auth parameters:
# https://circleci.com/developer/orbs/orb/circleci/gcp-gcr#commands-gcr-auth
- gcp-gcr/gcr-auth:
gcp_cred_config_file_path: ~/gcp_cred_config.json
google-project-id: GCP_PROJECT_ID
registry-url: <<parameters.registry-url>>
service_account_email: GCP_SERVICE_ACCOUNT_EMAIL
use_oidc: true
workload_identity_pool_id: GCP_WIP_ID
workload_identity_pool_provider_id: GCP_WIP_PROVIDER_ID
- run:
Expand All @@ -443,6 +446,8 @@ jobs:
source $BASH_ENV
docker tag <<parameters.image>>:<<parameters.build_tag>> $GAR_IMAGE:$GAR_TAG
docker tag <<parameters.image>>:<<parameters.build_tag>> $GAR_IMAGE:latest
# push-image parameters:
# https://circleci.com/developer/orbs/orb/circleci/gcp-gcr#commands-push-image
- gcp-gcr/push-image:
image: $GAR_IMAGE
google-project-id: GCP_PROJECT_ID
Expand Down

0 comments on commit b3740a8

Please sign in to comment.