fix: don't add_channels when there's none to add (#634)

Closes: SYNC-4154
mozilla-services · Feb 22, 2024 · b0ffa8c · b0ffa8c
1 parent 2540ff8
commit b0ffa8c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/autopush-common/src/db/dual/mod.rs b/autopush-common/src/db/dual/mod.rs
@@ -192,9 +192,11 @@ impl DbClient for DualClientImpl {
                         self.primary.add_user(&user).await?;
                         self.metrics.incr_with_tags("database.migrate").send();
                         let channels = self.secondary.get_channels(uaid).await?;
-                        // NOTE: add_channels doesn't write a new version:
-                        // user.version is still valid
-                        self.primary.add_channels(uaid, channels).await?;
+                        if !channels.is_empty() {
+                            // NOTE: add_channels doesn't write a new version:
+                            // user.version is still valid
+                            self.primary.add_channels(uaid, channels).await?;
+                        }
                         return Ok(Some(user));
                     }
                 }