This repository has been archived by the owner on Oct 15, 2021. It is now read-only.
Handle missing add-on blockID. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2017 11:47
leplatrem
approved these changes
Feb 20, 2017
| else: | ||
| emItem = etree.SubElement(emItems, 'emItem', | ||
| blockID=item['blockID']) | ||
| blockID=item.get('blockID', item['id'])) |
There was a problem hiding this comment.
we have emItem.set('id' a few lines below, it's hard to follow without comment
There was a problem hiding this comment.
I don't understand this comment, the item id is the guid (add-on id not the kinto blocklist id)
amo2kinto/exporter.py
Outdated
| # Group by and keep the biggest blockID in the XML file. | ||
| if current_blockID > previous_blockID: | ||
| emItem.attrib['blockID'] = item['blockID'] | ||
| if 'blockID' in item: |
There was a problem hiding this comment.
A small comment explaining that in the new system blockID is not mandatory, but id is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.