Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Exit PiP when launched externally with Intents #6768

Merged

Conversation

ionutbedregeanu
Copy link
Contributor

@ionutbedregeanu ionutbedregeanu commented Mar 28, 2022

For #6755

pip.mp4

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to build-focus-debug or build-klar-debug for changes targeting Klar,
  3. click View task in Taskcluster,
  4. click the Artifacts row,
  5. click to download any of the apks listed here which use an appropriate name for each CPU architecture.

@ionutbedregeanu ionutbedregeanu added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 28, 2022
@rocketsroger
Copy link
Contributor

rocketsroger commented Mar 29, 2022

From test it works. But when I did the following:

  1. open Focus and start streaming from youtube, set to full screen.
  2. swipe up and go to home (device home) to trigger PiP.
  3. open Fenix go to google.com, share to focus

Expected:
4. PiP dismissed, google.com opened. Focus should be now showing in portrait orientation.

Actual:
4. PiP dismissed, google.com opened. Focus stuck in landscape mode and doesn't matter how I rotate the device it won't switch to portrait mode.

@Mugurell
Copy link
Contributor

Actual: 4. PiP dismissed, google.com opened. Focus stuck in landscape mode and doesn't matter how I rotate the device it won't switch to portrait mode.

Sounds like a race between
handling the new intent and
exiting fullscreen which would trigger exiting immersive mode and unlocking the orientation,
similar to the mozilla-mobile/fenix#24040 Fenix issue.

@ionutbedregeanu ionutbedregeanu removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 30, 2022
@ionutbedregeanu ionutbedregeanu marked this pull request as draft March 30, 2022 06:23
@ionutbedregeanu ionutbedregeanu marked this pull request as ready for review March 30, 2022 11:08
@ionutbedregeanu
Copy link
Contributor Author

From test it works. But when I did the following:

  1. open Focus and start streaming from youtube, set to full screen.
  2. swipe up and go to home (device home) to trigger PiP.
  3. open Fenix go to google.com, share to focus

Expected: 4. PiP dismissed, google.com opened. Focus should be now showing in portrait orientation.

Actual: 4. PiP dismissed, google.com opened. Focus stuck in landscape mode and doesn't matter how I rotate the device it won't switch to portrait mode.

@rocketsroger First of all thanks for review.
I took a look and it seems a different bug, which can be reproduced also if we are trying to open a home screen shortcut while PiP is active. In my opinion we should create a separate ticket for it

@ionutbedregeanu ionutbedregeanu added the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 5, 2022
@ionutbedregeanu
Copy link
Contributor Author

New ticket created for #6768 (comment)

@ionutbedregeanu
Copy link
Contributor Author

@rocketsroger Can you help with an r here?

@ionutbedregeanu ionutbedregeanu added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Apr 20, 2022
@mergify mergify bot merged commit a2824df into mozilla-mobile:main Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants