-
Notifications
You must be signed in to change notification settings - Fork 711
Issue #4901: Update metrics for data review on initial metrics #5065
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travis79 Thanks for review! I've made the appropriate changes.
Glean integration will be going out in our next release, so I'll need to cherry-pick this patch to that release branch. Would I need another data review for that?
So long as the metrics.yaml points to the review I'm getting ready to add to this i |
Data Review
Yes, through the metrics.yaml file and the Glean Dictionary
Yes, through the "Send Usage Data" toggle in the app preferences
Yes, for the two metrics listed as permanent, @jonalmeida will monitor them
Category 2, User Interaction
Default-on
No
Yes
No Resultdata-review+ |
I need to escalate the review for category 4 identifiers just to ensure legal is aware. It shouldn't be a problem since we are only duplicating what we have already done in Fenix but let's follow the procedures on this. I'll review the second request in this issue as soon as possible, after we get a response on this. |
Relman would like to get a build for the next Focus release out and I didn't anticipate how the timeline needed for this (my error!). For that reason, I'm going to disable the activation_id telemetry and remove it from the metrics file with a separate issue that can land at a comfortable timeline for everyone. |
@Mergifyio backport releases_v91.0 |
Command
|
@travis79 I tried to separate out the data review into two requests to make it a bit easier: one for browser metrics, the other for activation and legacy IDs for deletion.