Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Renew telemetry for is_fenix_default_browser in Focus (and it's variants) #6299

Closed
jonalmeida opened this issue Jan 26, 2022 · 5 comments
Closed
Assignees
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jan 26, 2022

Each metric in the following list from firefox-focus-android, firefox-focus-android-beta, firefox-focus-android-nightly, and firefox-klar-android will expire in the next 14 days or has already expired.

- mozilla_products.is_fenix_default_browser on 2022-02-01

What to do about this:

1. If the metric is no longer needed, remove it from its `metrics.yaml` [1] file.
2. If the metric is still required, resubmit a data review [2] and extend its expiration date.

If you have any problems, please ask for help on the #glean Matrix channel[3]. We'll give you a hand.

What happens if you don't fix this:

The metrics listed above will stop collecting data from builds built after this expiration date,
and you will continue to get this e-mail as a reminder.

Your Friendly, Neighborhood Glean Team

[1] The correct metrics.yaml is in this list:
https://github.com/mozilla-mobile/focus-android/tree/HEAD/app/metrics.yaml
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://chat.mozilla.org/#/room/#glean:mozilla.org

cc: @amedyne

@amedyne
Copy link
Contributor

amedyne commented Jan 26, 2022

@channingcarter do we need to renew this metric?

@channingcarter
Copy link

Yes @amedyne

@ionutbedregeanu ionutbedregeanu self-assigned this Jan 28, 2022
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Jan 31, 2022
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Jan 31, 2022
mergify bot pushed a commit that referenced this issue Jan 31, 2022
mergify bot pushed a commit that referenced this issue Jan 31, 2022
jonalmeida pushed a commit that referenced this issue Jan 31, 2022
jonalmeida pushed a commit that referenced this issue Jan 31, 2022
@ionutbedregeanu ionutbedregeanu added the QAReady flag for test read & needed label Feb 1, 2022
@AndiAJ
Copy link
Contributor

AndiAJ commented Feb 1, 2022

Hi, I've checked if the probe is renewed in the Glean dictionary and it looks like it's expired.

On the other hand, I've manually generated the metrics ping (set the date to 2/1 and time to 04:00 AM) and the probe was successfully generated. Glean dashboard

I'll remove the QAReady label until further notice.

@AndiAJ AndiAJ removed the QAReady flag for test read & needed label Feb 1, 2022
@ionutbedregeanu ionutbedregeanu added this to the 98 milestone Feb 7, 2022
@ionutbedregeanu
Copy link
Contributor

I will move this ticket to done until further notice

@lobontiumira
Copy link

The telemetry was renewed for is_fenix_default_browser in the Glean dictionary.
I will close this ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants