Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Search bar won't accept an URL containing a colon #4587

Closed
zekooooo opened this issue Jul 6, 2020 · 9 comments
Closed

Search bar won't accept an URL containing a colon #4587

zekooooo opened this issue Jul 6, 2020 · 9 comments
Assignees

Comments

@zekooooo
Copy link

zekooooo commented Jul 6, 2020

When I input an URL that contains a colon, but omit the protocol ("https://"), for example: en.wikipedia.org/wiki/Dracula:_Dead_and_Loving_It, pressing Enter doesn't do anything.

If the URL doesn't contain a : outside the protocol and/or I've input the protocol, the page is normally loaded.

Using Klar 8.4.0 on Android 7.

@lobontiumira
Copy link

I can confirm this issue, with a minor difference.
After tapping enter for the en.wikipedia.org/wiki/Dracula:_Dead_and_Loving_It page, the "Open in app" prompt is displayed.
Tapping on Cancel, or Open just dismisses the prompt, and turns the page blank.

colon

Tested on the latest Focus Nightly 100.0a1 from 3/18 with Samsung Galaxy Note 8 (Android 9).

@lobontiumira
Copy link

lobontiumira commented Jul 13, 2022

This issue still reproduces on the latest Focus Nightly 104.0a1 from 7/13 with Oppo Reno 6 (Android 12).
After loading en.wikipedia.org/wiki/Dracula:_Dead_and_Loving_It page, the "Open in app" prompt is displayed.
Tapping on Cancel, or Open just dismisses the prompt, and turns the page blank.

Note: Fenix Nightly 104.0a1 opens the page without issues.

@ionutbedregeanu
Copy link
Contributor

Both apps(Fenix and Focus) add a new tab with url = en.wikipedia.org/wiki/Dracula:_Dead_and_Loving_It but the request interceptor receives a diferent value. Fenix receives the url formatted with "https" while Focus receives the url without any changes.Maybe someone else, which has more context, can also take a look.

@ionutbedregeanu
Copy link
Contributor

ionutbedregeanu commented Sep 9, 2022

fun interceptsAppInitiatedRequests() from RequestInterceptor- Thats the difference between Focus and Fenix and that cause this behaviour from Focus
Focus overrides this to true and in Fenix keep it false(default value), but I'm reading the documentation and I'm a bit confused. Shouldn't be also true in Fenix?
@jonalmeida Can you help me with this? Do you have more details?

@ionutbedregeanu ionutbedregeanu removed their assignment Sep 12, 2022
@mcarare
Copy link
Contributor

mcarare commented Oct 6, 2022

This should be rechecked after #7777 is fixed, looking at the last STR it seems to be the same as in #7777.

@mcarare mcarare added the waiting label Oct 6, 2022
@iorgamgabriel iorgamgabriel self-assigned this Oct 13, 2022
@iorgamgabriel iorgamgabriel added the QAReady flag for test read & needed label Oct 13, 2022
@rocketsroger
Copy link
Contributor

Looks like this requires some changes from the GeckoView side. I'll take this issue and work on the GeckoView change.

@Mugurell
Copy link
Contributor

Looks like this requires some changes from the GeckoView side. I'll take this issue and work on the GeckoView change.

Maybe you saw already, the difference between Fenix and Focus, why this works on Fenix and not on Focus is again interceptsAppInitiatedRequests() = true - on Fenix it is by default false.

@rocketsroger
Copy link
Contributor

Maybe you saw already, the difference between Fenix and Focus, why this works on Fenix and not on Focus is again interceptsAppInitiatedRequests() = true - on Fenix it is by default false.

Yes, @iorgamgabriel pointed it out when I couldn't figure out the difference. 😅

@rocketsroger rocketsroger removed the QAReady flag for test read & needed label Oct 13, 2022
@cpeterso
Copy link
Collaborator

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802666

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants