Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXIOS-868 ⁃ #7069: Top Sites and Open Tabs Widget #7283

Merged
merged 6 commits into from
Sep 18, 2020
Merged

FXIOS-868 ⁃ #7069: Top Sites and Open Tabs Widget #7283

merged 6 commits into from
Sep 18, 2020

Conversation

nbhasin2
Copy link
Contributor

@nbhasin2 nbhasin2 commented Sep 9, 2020

Fix issue with white border on quickLinks widget

(cherry picked from commit 75c6f5ae3d0d2b2802a482f064042bd4d3c1134c)

┆Issue is synchronized with this Jira Task

Fix issue with white border on quickLinks widget

(cherry picked from commit 75c6f5ae3d0d2b2802a482f064042bd4d3c1134c)
@nbhasin2 nbhasin2 changed the title For #7069: Add Open Tabs widget For #7069: Top Sites and Open Tabs Widget Sep 9, 2020
@nbhasin2 nbhasin2 changed the title For #7069: Top Sites and Open Tabs Widget #7069: Top Sites and Open Tabs Widget Sep 9, 2020
@data-sync-user data-sync-user changed the title #7069: Top Sites and Open Tabs Widget FXIOS-868 ⁃ #7069: Top Sites and Open Tabs Widget Sep 9, 2020
@@ -376,6 +377,10 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UIViewControllerRestorati
} else {
syncOnDidEnterBackground(application: application)
}

tabManager.preserveTabs()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spacing

@nbhasin2
Copy link
Contributor Author

@garvankeeley I commented out files for widgets that require refactoring but let me know if there is a better way to deprecate files, I can remove the files completely or comment them out.

Copy link
Contributor

@garvankeeley garvankeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land so we can get main healthy again. We have an xcode 12 build of A-S lib on there now.

@garvankeeley
Copy link
Contributor

Sigh, tired of waiting for BB to finish building. Merging to master and running Bitrise to see if I can get iOS14 builds going there again.

@garvankeeley garvankeeley merged commit 7f067dc into mozilla-mobile:main Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants