Fix #5999 -Tabs tray button is not consistent with other buttons when tapped #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'View Tabs' button behaved differently from the other buttons. After pressing on the toolbar - button frame disappeared, instead of turning blue (like the other buttons):
https://monosnap.com/file/rqyCVEvJSXll87dDQvZBPXKaqFkTjm
The back/forward/refresh/menu button were in the Theme file, and Tabs Button was in the different file. After changing previous 'clear' colour to 'blue40' 'View Tabs' button in the toolbar behaved like the rest of the buttons.
https://monosnap.com/file/C6mBbuPiYmCx6zYK1xJbMGkIAND9aX
(same behaviour in the regular tab)
P.S. the link for the old PR #6007
I was figuring out how to clean commit history mess and ended up removing the necessary branch.