Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5974: sql cipher plaintext header and salt #5990

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Fix #5974: sql cipher plaintext header and salt #5990

merged 2 commits into from
Jan 8, 2020

Conversation

garvankeeley
Copy link
Contributor

No description provided.

@mozillamobilebot
Copy link

SwiftLint found issues

Warnings

File Line Reason
Profile.swift 1163 Prefer empty collection over optional collection. (discouraged_optional_collection)
Profile.swift 440 Force tries should be avoided. (force_try)
Profile.swift 553 Force tries should be avoided. (force_try)
Profile.swift 905 Fallthroughs can only be used if the case contains at least one other statement. (no_fallthrough_only)

Sentry check list

  • I understand that only .fatal events will be reported on release

  • The message param contains a string that will not create multiple events

Generated by 🚫 Danger

@garvankeeley garvankeeley merged commit bf118e4 into mozilla-mobile:master Jan 8, 2020
@kaylagalway kaylagalway mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garvankeeley @mozillamobilebot @nbhasin2