Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5714 - ETP label is truncated in Settings #5828

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Fix #5714 - ETP label is truncated in Settings #5828

merged 1 commit into from
Nov 28, 2019

Conversation

nbhasin2
Copy link
Contributor

  • Set the ETP label to support multiple lines of text instead of single line
  • Fixed the issue where the ETP label was truncated for longer strings in some languages (Eg. French)

@nbhasin2 nbhasin2 marked this pull request as ready for review November 28, 2019 19:37
@nbhasin2 nbhasin2 merged commit f601df0 into mozilla-mobile:master Nov 28, 2019
@nbhasin2 nbhasin2 deleted the nb/5714-ETP_Label_Truncated_Fix branch November 28, 2019 21:20
garvankeeley pushed a commit that referenced this pull request Dec 2, 2019
@nbhasin2 @garvankeeley
Fix #5714 - ETP label is truncated in Settings (#5828)
f1929ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garvankeeley garvankeeley garvankeeley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbhasin2 @garvankeeley