Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nobug, api update] Use WKWebsiteDataStore.allWebsiteDataTypes when clearing private data #5808

Merged

Conversation

garvankeeley
Copy link
Contributor

I found this function when browsing the API, we should be using it.

@mozillamobilebot
Copy link

SwiftLint found issues

Warnings

File Line Reason
Tab.swift 192 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Tab.swift 364 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 368 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 562 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 257 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

Errors

File Line Reason
Tab.swift 397 There should be no space before and one after any comma. (comma)

Generated by 🚫 Danger

@garvankeeley garvankeeley merged commit e22eb5d into mozilla-mobile:master Nov 25, 2019
@garvankeeley garvankeeley deleted the gk/nobug-update-pb-datatypes branch April 8, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants