Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5345: Make it easier to navigate to synced tabs #5743

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

q2r5
Copy link
Contributor

@q2r5 q2r5 commented Nov 11, 2019

Fixes #5345

@mozillamobilebot
Copy link

1 Warning
⚠️ NSLocalizedString should only be added to Strings.swift

SwiftLint found issues

Warnings

File Line Reason
RemoteTabsPanel.swift 617 Prefer empty collection over optional collection. (discouraged_optional_collection)
RemoteTabsPanel.swift 137 Force casts should be avoided. (force_cast)
RemoteTabsPanel.swift 182 Force casts should be avoided. (force_cast)
HistoryPanel.swift 515 Prefer empty collection over optional collection. (discouraged_optional_collection)
HistoryPanel.swift 623 Prefer empty collection over optional collection. (discouraged_optional_collection)
FirefoxHomeViewController.swift 109 Prefer empty collection over optional collection. (discouraged_optional_collection)
FirefoxHomeViewController.swift 768 Prefer empty collection over optional collection. (discouraged_optional_collection)
FirefoxHomeViewController.swift 359 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 389 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 413 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 509 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 521 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 530 Force casts should be avoided. (force_cast)
FirefoxHomeViewController.swift 691 Force casts should be avoided. (force_cast)
Strings.swift 651 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

Errors

File Line Reason
FirefoxHomeViewController.swift 985 Lines should not have trailing semicolons. (trailing_semicolon)

Generated by 🚫 Danger

@garvankeeley garvankeeley self-requested a review November 12, 2019 20:20
Copy link
Contributor

@garvankeeley garvankeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@garvankeeley garvankeeley merged commit 21794c5 into mozilla-mobile:master Nov 14, 2019
@q2r5 q2r5 deleted the issue5345 branch April 23, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to navigate to synced tabs
3 participants