Change the Launch Screen to use System Background Color #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound color, so that people in dark mode aren't blinded when they open the app (forces a darker background instead of white)
| @@ -18,7 +21,7 @@ | |||
| </constraints> | |||
| </imageView> | |||
| </subviews> | |||
| <color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="calibratedWhite"/> | |||
| <color key="backgroundColor" systemColor="systemBackgroundColor" cocoaTouchSystemColor="whiteColor"/> | |||
There was a problem hiding this comment.
Thanks for the PR! Can you unstage the other changes if this is the only needed change? Thanks
There was a problem hiding this comment.
Should be good now!
|
Sure, can do this afternoon.
… On Oct 16, 2019, at 11:07, Garvan Keeley ***@***.***> wrote:
@garvankeeley commented on this pull request.
In Client/Application/LaunchScreen.xib:
> @@ -18,7 +21,7 @@
</constraints>
</imageView>
</subviews>
- <color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="calibratedWhite"/>
+ <color key="backgroundColor" systemColor="systemBackgroundColor" cocoaTouchSystemColor="whiteColor"/>
Thanks for the PR! Can you unstage the other changes if this is the only needed change? Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
garvankeeley
approved these changes
Oct 18, 2019
garvankeeley
added a commit
that referenced
this pull request
Oct 21, 2019
This reverts commit 6eca44a.
garvankeeley
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Change the Launch Screen to use System Background Color as the background color, so that people in dark mode aren't blinded when they open the app (forces a darker background instead of white) * Clean up LaunchScreen.xib to only change the systemBackgroundColor item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Launch Screen xib to use the system background color rather than stock white. Currently on iOS13 when you open the app it's a (blinding) white - i.e, my wife becomes annoyed when I do this at night. :)
By using the system background color, iOS will make it black or white depending on if the user has dark mode toggled in their settings.
Slightly unrelated, but you may want to push out a release of this soon if possible - unless I'm mistaken, the App Store version isn't linked against iOS13, and
WKWebViewisn't respectingprefers-dark-colorsin CSS as a result. I can file it as a bug if you'd like, but it feels like overkill considering any release would hit it.