-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-10617 [ToS] Add Glean usage profile id #23254
Merged
+53
−1
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a6df939
Add pref key
thatswinnie 4c3a0e2
Add usage metric
thatswinnie bbf9033
Set or generate profile id
thatswinnie 33f1fde
Delete profile id when user turns off reporting
thatswinnie 424f0e8
Merge remote-tracking branch 'mozilla/main' into wt/FXIOS-10617-Add-G…
thatswinnie b3832ef
Update firefox-ios/Client/metrics.yaml
thatswinnie da4e2f2
Update firefox-ios/Client/metrics.yaml
thatswinnie 442ce32
Update firefox-ios/Client/Frontend/Settings/Main/Support/SendAnonymou…
thatswinnie ec45364
Update metrics
thatswinnie 97daa50
Fix build error
thatswinnie 56da59e
Addressing PR comments
thatswinnie 68913ec
Merge remote-tracking branch 'mozilla/main' into wt/FXIOS-10617-Add-G…
thatswinnie 5ab7ffc
Update firefox-ios/Client/Telemetry/TelemetryWrapper.swift
thatswinnie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -709,6 +709,28 @@ app: | |
- [email protected] | ||
expires: "2025-01-01" | ||
|
||
# Usage reporting | ||
usage: | ||
profile_id: | ||
type: uuid | ||
lifetime: user | ||
description: | | ||
A UUID uniquely identifying the profile, | ||
not shared with other telemetry data. | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/23254 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/23254 | ||
data_sensitivity: | ||
- technical | ||
- highly_sensitive | ||
notification_emails: | ||
- [email protected] | ||
thatswinnie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- [email protected] | ||
expires: never | ||
send_in_pings: | ||
- usage-reporting | ||
|
||
# Downloads | ||
downloads: | ||
download_now_button_tapped: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't knew Winnie liked beef that much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c0ffee (and decaf) were already taken and I couldn't come up with other fun stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL. I like beef and I cannot lie 😇
But seriously, that string actually came from @badboy