Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10200 WKWebView showing gray background while loading content #22689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix FXIOS-10200 WKWebView showing gray background while loading content #22689

wants to merge 1 commit into from

Conversation

FilippoZazzeroni
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Bugfix WKWebView showing gray background while loading content. Now the content background while loading has been replaced with transparent background, but can be modified to any color.

Simulator.Screen.Recording.-.iPhone.15.-.2024-10-22.at.14.01.43.mp4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@FilippoZazzeroni FilippoZazzeroni requested a review from a team as a code owner October 22, 2024 12:06
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 31.89%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 30.5

File Coverage
TabManagerNavDelegate.swift 88.42% ✅
Tab.swift 44.98% ⚠️

Generated by 🚫 Danger Swift against 4b11c49

PARAIPAN9
PARAIPAN9 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FilippoZazzeroni FilippoZazzeroni added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Oct 22, 2024
@FilippoZazzeroni
Copy link
Collaborator Author

Setting do not merge label, since noticed some UI glitches when pulling for refresh

@MattLichtenstein
Copy link
Collaborator

In light mode, I am sometimes seeing a black background

Simulator.Screen.Recording.-.iPhone.15.-.2024-10-22.at.12.09.11.mp4

@FilippoZazzeroni
Copy link
Collaborator Author

Thanks @MattLichtenstein i'm going to have a look it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PARAIPAN9 PARAIPAN9 PARAIPAN9 approved these changes

Assignees
No one assigned
Labels
Do Not Merge ⛔️ This issue is a work in progress and is not ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FilippoZazzeroni @mobiletest-ci-bot @MattLichtenstein @PARAIPAN9