[Looking for Feedback] Add FXIOS-10164 [Homepage] More Pocket Section Tests #22643
Conversation
| func test_enterForegroundAction_getPocketData() async throws { | ||
| let action = PocketAction(windowUUID: .XCTestDefaultUUID, actionType: PocketActionType.enteredForeground) | ||
| store.dispatch(action) | ||
| try await Task.sleep(nanoseconds: 1_000_000_000) |
There was a problem hiding this comment.
not sure how I feel about these sleeps, however, I am unable to think of another way without a larger refactor. If we could mock our store and monitor the dispatches, then we can use an expectation on that dispatch. In our current case our store is a global variable, so can't be mock properly and the alternative was to make it a var so that it can be overridden in tests.
| let pocketManager = MockPocketManager() | ||
| override func setUp() { | ||
| super.setUp() | ||
| DependencyHelperMock().bootstrapDependencies(injectedPocketManager: pocketManager) |
There was a problem hiding this comment.
to test these middlewares (more of an integration test over unit test); all dependencies will need to be injected through the DependencyHelper and this is because of how we are initializing our middlewares. Let me know if there's a better way to write these tests.
Client.app: Coverage: 30.48
Generated by 🚫 Danger Swift against 58b48ce |
📜 Tickets
Jira ticket
Github issue
💡 Description
Added some more tests for the homepage rebuild - pocket section. These tests are currently passing, but looking for some feedback if this should be the standard of how we do tests. Feel free to leave feedback and can respond when I return!
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)