Add FXIOS-9627-[Native Error Page] Initial changes for manager support #22613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharC95
force-pushed
the
tc/FXIOS-9627-NativeErrorPage-Manager
branch
from
103279c
to
e213824
Compare
tusharC95
force-pushed
the
tc/FXIOS-9627-NativeErrorPage-Manager
branch
from
2cacdf5
to
f7d4652
Compare
adudenamedruby
requested changes
Oct 24, 2024
| configureUI() | ||
| setupLayout() | ||
| adjustConstraints() | ||
| showViewForCurrentOrientation() | ||
| } | ||
|
|
||
| // MARK: Redux | ||
| func newState(state: NativeErrorPageState) { | ||
| // if state.title != nil { |
| @@ -89,37 +89,67 @@ final class NativeErrorPageViewController: UIViewController, | |||
|
|
|||
| private var contraintsList = [NSLayoutConstraint]() | |||
|
|
|||
| required init?( | |||
There was a problem hiding this comment.
How come we're removing this?
| } | ||
|
|
||
| static let reducer: Reducer<Self> = { state, action in | ||
| print(action.actionType) |
There was a problem hiding this comment.
we shouldn't have these statements in production
|
|
||
| static let reducer: Reducer<Self> = { state, action in | ||
| print(action.actionType) | ||
| guard action.windowUUID == .unavailable || action.windowUUID == state.windowUUID else { return NativeErrorPageState( |
There was a problem hiding this comment.
nit: return can be on a separate line here
| title: state.title, | ||
| description: state.description | ||
| )} | ||
| switch action.actionType { |
There was a problem hiding this comment.
nit: leave some space so it's easier to read. Vertical space is free, we may as well take advantage!
| )} | ||
| switch action.actionType { | ||
| case NativeErrorPageMiddlewareActionType.initialize: | ||
| guard let action = action as? NativeErrorPageAction, let model = action.nativePageErrorModel else { |
There was a problem hiding this comment.
nit: spread the multiple let conditions over multiple lines for easy reading
Comment on lines
+26
to
+30
| let newAction = NativeErrorPageAction(nativePageErrorModel: model, | ||
| windowUUID: windowUUID, | ||
| actionType: NativeErrorPageMiddlewareActionType.initialize | ||
| ) | ||
| store.dispatch(newAction) |
There was a problem hiding this comment.
Suggested change
| let newAction = NativeErrorPageAction(nativePageErrorModel: model, | |
| windowUUID: windowUUID, | |
| actionType: NativeErrorPageMiddlewareActionType.initialize | |
| ) | |
| store.dispatch(newAction) | |
| store.dispatch( | |
| NativeErrorPageAction(nativePageErrorModel: model, | |
| windowUUID: windowUUID, | |
| actionType: NativeErrorPageMiddlewareActionType.initialize | |
| ) | |
| ) |
nit: alternative to consider that doesn't require assignment.
| final class NativeErrorPageMiddleware { | ||
| lazy var nativeErrorPageProvider: Middleware<AppState> = { state, action in | ||
| let windowUUID = action.windowUUID | ||
| print(action.actionType) |
There was a problem hiding this comment.
no need for print statements in prod
| lazy var nativeErrorPageProvider: Middleware<AppState> = { state, action in | ||
| let windowUUID = action.windowUUID | ||
| print(action.actionType) | ||
| switch action.actionType { |
There was a problem hiding this comment.
spppaaaaaaccccceeeee :P
| func parseErrorDetails() -> ErrorPageModel { | ||
| var title = "" | ||
| var description = "" | ||
| switch error.code { |
There was a problem hiding this comment.
Space for readibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)