Bugfix FXIOS-9483 Bugzilla 1905749

[nbhasin2]

📜 Tickets

Jira ticket
https://bugzilla.mozilla.org/show_bug.cgi?id=1905749

💡 Description

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[mattreaganmozilla]

Initial changes LGTM, do we have clear repro steps for validating? I noticed your recent comment on the Bugzilla, looks like there still might be details we're trying to clarify with the reporter?

[mattreaganmozilla]

@nbhasin2 Quick follow-up: is there any update on this? LMK if you want to sync further or hand this ticket off etc.

[nbhasin2]

@mattreaganmozilla handing over to you, let me know if this fix is good enough for the time being

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 31.91%
📖	Edited 3 files
📖	Created 0 files

Client.app: Coverage: 30.52

File	Coverage
BrowserViewController+WebViewDelegates.swift	4.6%	⚠️
WebViewNavigationHandler.swift	100.0%	✅
LegacyTabManager.swift	38.56%	⚠️

Generated by 🚫 Danger Swift against 82f313e

[mattreaganmozilla]

@nbhasin2 I reviewed the Bugzilla again and compared the behavior in this branch vs main and this looks Ok to me. Based on what I can see in the ticket I think we should be good to merge this and have QA validate and/or clarify any remaining questions with the reporter if needed.

[mattreaganmozilla]

@nbhasin2 Just double-checking: any concerns with me merging?

[nbhasin2]

@nbhasin2 Just double-checking: any concerns with me merging?

No concern from my end, thanks for reviewing!!