-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix FXIOS-9483 Bugzilla 1905749 #22519
Bugfix FXIOS-9483 Bugzilla 1905749 #22519
Conversation
Initial changes LGTM, do we have clear repro steps for validating? I noticed your recent comment on the Bugzilla, looks like there still might be details we're trying to clarify with the reporter? |
@nbhasin2 Quick follow-up: is there any update on this? LMK if you want to sync further or hand this ticket off etc. |
@mattreaganmozilla handing over to you, let me know if this fix is good enough for the time being |
Client.app: Coverage: 30.52
Generated by 🚫 Danger Swift against 82f313e |
@nbhasin2 I reviewed the Bugzilla again and compared the behavior in this branch vs |
@nbhasin2 Just double-checking: any concerns with me merging? |
No concern from my end, thanks for reviewing!! |
📜 Tickets
Jira ticket
https://bugzilla.mozilla.org/show_bug.cgi?id=1905749
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)