Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9683 [Unit Tests] Tab Peek State tests #22043

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add FXIOS-9683 [Unit Tests] Tab Peek State tests #22043

merged 1 commit into from
Sep 18, 2024

Conversation

cyndichin
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Add unit tests to check state for different cases for actions reduced in TabPeekState

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@cyndichin
Copy link
Contributor Author

@dataports thinking about opening some of these tests to contributors, but thought I'll get a one in and take a break from dealing with flaky tests 🤣

@cyndichin cyndichin marked this pull request as ready for review September 17, 2024 20:23
@cyndichin cyndichin requested a review from a team as a code owner September 17, 2024 20:23
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 1 files

Generated by 🚫 Danger Swift against 4866647

dataports
dataports approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dataports dataports left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@cyndichin cyndichin merged commit 07f0c49 into main Sep 18, 2024
8 of 10 checks passed
@cyndichin cyndichin deleted the cc/FXIOS-9683_add-tab-peek-state-tests branch September 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataports dataports dataports approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyndichin @mobiletest-ci-bot @dataports