Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9709 - Add a11y custom action to reader mode button #21541

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Add FXIOS-9709 - Add a11y custom action to reader mode button #21541

merged 3 commits into from
Aug 21, 2024

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Aug 16, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add a11y custom action to reader mode button

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner August 16, 2024 14:17
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Aug 16, 2024 •
edited
Loading

Messages
📖 Project coverage: 31.65%
📖 Edited 11 files
📖 Created 0 files

Client.app: Coverage: 30.36

File Coverage
GeneralBrowserAction.swift 60.0% ✅
BrowserViewController.swift 5.04% ⚠️
NavigationToolbarContainerModel.swift 0.0% ⚠️
BrowserViewController+URLBarDelegate.swift 3.41% ⚠️
AddressToolbarContainerModel.swift 32.99% ⚠️
BrowserViewControllerState.swift 25.14% ⚠️
ToolbarActionState.swift 0.0% ⚠️
ToolbarAction.swift 0.0% ⚠️
ToolbarMiddleware.swift 1.76% ⚠️

Generated by 🚫 Danger Swift against aacd0b8

@thatswinnie thatswinnie merged commit 107055c into main Aug 21, 2024
13 checks passed
@thatswinnie thatswinnie deleted the sparaipan/fxios-9709-Add-a11y-custom-action-to-reader-mode-button branch August 21, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PARAIPAN9 @mobiletest-ci-bot @thatswinnie