Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Theme isn't reset properly #9788

Closed
lmarceau opened this issue Jan 14, 2022 · 2 comments
Closed

System Theme isn't reset properly #9788

lmarceau opened this issue Jan 14, 2022 · 2 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA

Comments

@lmarceau
Copy link
Contributor

lmarceau commented Jan 14, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open Settings > Theme
  2. Turn off "Use System Light/Dark Mode"
  3. Change the theme with the theme picker (in my case I selected Dark).
  4. Toggle "Use System Light/Dark Mode" again

Expected behavior

Should be reset to use light mode

Actual behavior

Stays on dark mode. If I toggle it again, the second time it properly reset the theme.

Device & build information

  • Device: iPhone on iOS 15.0
  • Build version: main dd5e01

Notes

Attachments:

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-01-14.at.17.05.27.mp4

┆Issue is synchronized with this Jira Task
@lmarceau lmarceau added Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project labels Jan 14, 2022
@junbio junbio mentioned this issue Jan 18, 2022
Closed
@data-sync-user data-sync-user added the P2 Issues that need to be completed after all P1 issues are completed for the current release label Jan 20, 2022
@junbio junbio mentioned this issue Jan 24, 2022
Merged
lmarceau pushed a commit that referenced this issue Jan 25, 2022
@junbio
Bugfix #9788 [v98] System theme not changing when enabled in settings (…
1591b48 
…#9850)

* Update ThemeSettingsController.swift - System theme not changing when enabled in settings
@lmarceau lmarceau added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label Jan 25, 2022
@csuciu
Copy link

csuciu commented Jan 27, 2022

Verifying as fixed on latest master.

@csuciu csuciu closed this as completed Jan 27, 2022
@data-sync-user data-sync-user removed the Contributor OK This is a good issue for contributors interested in helping the project label Jan 27, 2022
@SimonBasca
Copy link
Contributor

Verified fix on v98.0 (8023).

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@csuciu @lmarceau @SimonBasca @data-sync-user