-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label for Synced tabs is smaller than the other labels on Library panels view #5853
Comments
Suggested fix:
|
Thanks for filing! There seem to be a few issues here, I'll try to capture it all. So if we update the en-GB translation on Pontoon, that will only fix our en-GB version. But it won't fix the other problem, which is that many other languages will continue to truncate - and in some cases this means losing a lot of the sense of the "Synced tabs" string. I checked French for example, and like some other languages the text is cut off from the screen, which makes it hard to understand what this is about (granted, the sync arrow image helps understand - but still). I think it may be good to make sure that all locales are aware that there is very limited space for this string, in order for them to find a workaround (note the size of a localized string is in general up to 25% longer than in en-US, so with mobile, we unfortunately often reach this issue a lot). In order to do this, you would have to add a specific recommendation in the localization comments for this string, asking to try and not exceed a certain number of letters if possible, because otherwise it will truncate. This will let localizers know they need to update their string and possibly abbreviate it - or even form it in a way that the sense of the words won't be lost, even if it truncates. Concerning adding the recommendation in the localization notes, there are a few ways you can go about this:
I think how we go about this should be a Product decision. (also, small nit: the proposed en-GB string in Pontoon reads "Synched" instead of "Synced". I can ping the localizer for an update though, once a decision on how to move forwards is reached ;) ) |
I like the idea you had update the IDs and add a new comment on these strings that they need to be kept as short as possible. |
…nt to keep strings short
Verified as fixed on master 1c5d218. |
Seen on latest beta v21.x: 16860
Steps
Go to Library panels view
Look at the Synchronized tabs
Expected
All labels have the same size
Actual
See screenshot:
In case this helps, if I set the device to another language, the label is not translated but it fits correctly:
The text was updated successfully, but these errors were encountered: