Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Status bar is not visible #5684

Closed
SimonBasca opened this issue Oct 29, 2019 · 5 comments
Closed

iOS Status bar is not visible #5684

SimonBasca opened this issue Oct 29, 2019 · 5 comments
Assignees
@dnarcese
Labels
2 Story size iOS13 P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Milestone
v21 [Dec 3]

Comments

@SimonBasca
Copy link
Contributor

SimonBasca commented Oct 29, 2019 •
edited by athomasmoz
Loading

Logged via Bugzilla : https://bugzilla.mozilla.org/show_bug.cgi?id=1592176

iOS 13.1.3 on iPhone Xr

Settings Menu:

Pre-conditions:

  • Light theme selected.

Steps to reproduce:

  1. Open Settings menu

Actual results:

  • iOS status bar is not displayed.
    IMG_C4C1155072EE-1

System Dark Mode:

Pre-conditions:

  • FF light theme selected
  • System dark theme selected

Steps to reproduce:

  1. Open any webpage in FF

Actual results:

  • iOS status bar is not displayed.
@SimonBasca
Copy link
Contributor Author

This is also reproducible on webpages when iOS Theme is set to "Dark" and Firefox theme is set to "Light"

@athomasmoz
Copy link

This should be fixed. @SimonBasca do you mind testing on master?

@dnarcese dnarcese mentioned this issue Nov 5, 2019
Closed
@SimonBasca
Copy link
Contributor Author

Still reproducible on following the STR on master 29017f6

@athomasmoz athomasmoz added the P1 Issues that need to be completed for the current release label Nov 7, 2019
@athomasmoz athomasmoz changed the title iOS Status bar is not visible in Setting menu iOS Status bar is not visible Nov 7, 2019
@athomasmoz athomasmoz added P2 Issues that need to be completed after all P1 issues are completed for the current release and removed P1 Issues that need to be completed for the current release labels Nov 7, 2019
@athomasmoz
Copy link

Marking as a P2 because, although this is very visible now, it will happen less often once we match FF theme to system theme

@athomasmoz athomasmoz added this to the v21 [Dec 3] milestone Nov 7, 2019
dnarcese added a commit to dnarcese/firefox-ios that referenced this issue Nov 7, 2019
@dnarcese
Fix mozilla-mobile#5684: Status bar wrong colour in settings
bf3c1ce
@dnarcese dnarcese self-assigned this Nov 7, 2019
@dnarcese dnarcese added the 2 Story size label Nov 7, 2019
garvankeeley pushed a commit that referenced this issue Nov 15, 2019
@dnarcese @garvankeeley
Fix #5684: Status bar wrong colour in settings (#5735)
5050e3d
@SimonBasca
Copy link
Contributor Author

This issue is no longer reproducible after following the STR on build 20.2(16690)

@csuciu csuciu added the QA Verified Issue verified by QA label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnarcese dnarcese

Labels
2 Story size iOS13 P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
v21 [Dec 3]
Development

No branches or pull requests
4 participants
@csuciu @dnarcese @SimonBasca @athomasmoz