Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain theme elements are incorrect on iPad using split-screen #5629

Closed
cgioia opened this issue Oct 20, 2019 · 3 comments
Closed

Certain theme elements are incorrect on iPad using split-screen #5629

cgioia opened this issue Oct 20, 2019 · 3 comments

Comments

@cgioia
Copy link
Contributor

cgioia commented Oct 20, 2019

This issue is when using an iPad app in split-screen "compact" mode. This is when the view is compressed like on an iPhone. The issues I've found:

  • The new tab button, when viewed in the compact mode with the light theme, is shaded as if it were still in the iPad's top tab bar, and is too light for the background

  • The status bar text, when in compact mode with the light theme, is left as white text, and is illegible on the white background
@cgioia
Copy link
Contributor Author

cgioia commented Oct 20, 2019

I have fixes in-hand for this issue. Created this so that I can create a pull request shortly.

@cgioia cgioia mentioned this issue Oct 20, 2019
Merged
@garvankeeley
Copy link
Contributor

Untitled

garvankeeley pushed a commit that referenced this issue Nov 15, 2019
@cgioia @garvankeeley
Fix #5629: iPad split-screen theme elements (#5630)
ab86d6f 
* Apply tab button theme based on location.

Applying the theme based on UI idiom meant that the wrong theme was
selected if iPad was in split-screen compact mode.

* Change BVC status bar style to be based on top-tabs.

Hard-coding the exception to be based on iPad causes the theme to be incorrect
when using the iPad app in split-screen and the theme is light.
@SimonBasca
Copy link
Contributor

Verifying as fix on 20.2 (16690).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgioia @garvankeeley @SimonBasca