Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect snapshot in tabs tray after clearing search tabs #4969

Closed
SimonBasca opened this issue May 15, 2019 · 2 comments
Closed

Incorrect snapshot in tabs tray after clearing search tabs #4969

SimonBasca opened this issue May 15, 2019 · 2 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA

Comments

@SimonBasca
Copy link
Contributor

Build: 17.0 (15191)
Device: iPad Air 2
iOS: 11.4

Steps to reproduce:

  1. Open an empty tab
  2. Open a New Tab
  3. Go to twitter.com
  4. Open tabs tray
  5. Tap on the "Search Tabs" field
  6. Type 'Home' and delete the typed word

Actual results:

  • Two twitter.com tabs appear in tabs tray.

Note:

  • After tapping the 'x' in the 'Search Tabs' field the empty tab appears to be displayed correct.
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label May 15, 2019
@farhanpatel farhanpatel added the P3 Issues that would be nice to have for the current release label May 16, 2019
@KrystynaKruchkovska
Copy link
Contributor

KrystynaKruchkovska commented Nov 14, 2019 •
edited
Loading

I am able to reproduce it with step 6 modified a bit, when deleting the typed word I have to do it quite quickly letter by letter.
The problem is when we reload the collectionView of tabs, it's not fully reloaded . The only fix that I managed to find is setting flag evenIfHidden to true when calling metod refreshStore.
It doesn't work perfectly because we have an effect of blinking as described in comment in this method. I'm attaching the video how it works now. I've also checked that it doesn't make tabs screenshot blink in situation when this bug doesn't occur which is also in the video.

4696.mov.zip

I'm opening the pull request with this fix.

KrystynaKruchkovska added a commit to KrystynaKruchkovska/firefox-ios that referenced this issue Nov 14, 2019
@KrystynaKruchkovska
Fix mozilla-mobile#4969: Incorrect snapshot is displayed on emtpy tab…
848aea9 
… after following STR
@garvankeeley garvankeeley changed the title Incorrect snapshot is displayed on emtpy tab after following STR Incorrect snapshot in tabs tray after clearing search tabs Nov 20, 2019
@SimonBasca
Copy link
Contributor Author

Verifying as fix on 21.0 (16901)

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farhanpatel @SimonBasca @KrystynaKruchkovska