remove warnings (#5754)

* remove warnings * fix Migrate “English.lproj” (Deprecated)
mozilla-mobile · Nov 13, 2019 · dcecbb0 · dcecbb0
1 parent eb2023f
commit dcecbb0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/Client.xcodeproj/project.pbxproj b/Client.xcodeproj/project.pbxproj
@@ -4185,10 +4185,9 @@
 			};
 			buildConfigurationList = F84B21B91A090F8100AAB793 /* Build configuration list for PBXProject "Client" */;
 			compatibilityVersion = "Xcode 3.2";
-			developmentRegion = English;
+			developmentRegion = en;
 			hasScannedForEncodings = 0;
 			knownRegions = (
-				English,
 				en,
 				Base,
 			);

diff --git a/Client/Frontend/Browser/Punycode.swift b/Client/Frontend/Browser/Punycode.swift
@@ -117,7 +117,7 @@ extension String {
     }
 
     fileprivate func decode(_ punycode: String) -> String {
-        var input = Array(punycode)
+        let input = Array(punycode)
         var output = [Character]()
         var i = 0
         var n = initialN

diff --git a/Storage/Rust/RustLogins.swift b/Storage/Rust/RustLogins.swift
@@ -188,7 +188,7 @@ public class RustLogins {
             }
 
             do {
-                try self.storage.sync(unlockInfo: unlockInfo)
+                try _ = self.storage.sync(unlockInfo: unlockInfo)
                 deferred.fill(Maybe(success: ()))
             } catch let err as NSError {
                 if let loginsStoreError = err as? LoginsStoreError {

diff --git a/Storage/Rust/RustPlaces.swift b/Storage/Rust/RustPlaces.swift
@@ -291,7 +291,7 @@ public class RustPlaces {
             }
 
             do {
-                try self.api?.syncBookmarks(unlockInfo: unlockInfo)
+                try _ = self.api?.syncBookmarks(unlockInfo: unlockInfo)
                 deferred.fill(Maybe(success: ()))
             } catch let err as NSError {
                 if let placesError = err as? PlacesError {

diff --git a/Sync/StorageClient.swift b/Sync/StorageClient.swift
@@ -236,8 +236,8 @@ public struct ResponseMetadata {
         })
 
         self.status = status
-        alert = headers["x-weave-alert"] as? String
-        nextOffset = headers["x-weave-next-offset"] as? String
+        alert = headers["x-weave-alert"]
+        nextOffset = headers["x-weave-next-offset"]
         records = optionalUIntegerHeader(headers["x-weave-records"] as AnyObject?)
         quotaRemaining = optionalIntegerHeader(headers["x-weave-quota-remaining"] as AnyObject?)
         timestampMilliseconds = optionalSecondsHeader(headers["x-weave-timestamp"] as AnyObject?) ?? 0