Skip to content

Commit

Permalink
Fix #6085 - Unknown fxa login errors should not transition to separat…
Browse files Browse the repository at this point in the history
…ed, stay at same.
  • Loading branch information
garvankeeley committed Feb 4, 2020
1 parent 9b44aae commit d69445a
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions Account/FxALoginStateMachine.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ class FxALoginStateMachine {
log.error("Unsuccessful HTTP request: \(error.description)! Assuming error is transient and not transitioning.")
return same
} else {
log.error("Unknown error: \(error.description). Transitioning to Separated.")
return separated
log.error("Unknown error: \(error.description). Transitioning to same.")
return same
}
case let .local(localError) where localError.domain == NSURLErrorDomain:
log.warning("Local networking error: \(result.failureValue!). Assuming transient and not transitioning.")
Expand All @@ -116,8 +116,8 @@ class FxALoginStateMachine {
break
}
}
log.error("Unknown error: \(result.failureValue!). Transitioning to Separated.")
return separated
log.error("Unknown error: \(result.failureValue!). Transitioning to same.")
return same
}
}

Expand Down Expand Up @@ -156,8 +156,8 @@ class FxALoginStateMachine {
log.error("Unsuccessful HTTP request: \(error.description)! Assuming error is transient and not transitioning.")
return same
} else {
log.error("Unknown error: \(error.description). Transitioning to Separated.")
return separated
log.error("Unknown error: \(error.description). Transitioning to Same.")
return same
}
case let .local(localError) where localError.domain == NSURLErrorDomain:
log.warning("Local networking error: \(result.failureValue!). Assuming transient and not transitioning.")
Expand All @@ -166,8 +166,8 @@ class FxALoginStateMachine {
break
}
}
log.error("Unknown error: \(result.failureValue!). Transitioning to Separated.")
return separated
log.error("Unknown error: \(result.failureValue!). Transitioning to Same.")
return same
}
}

Expand Down

0 comments on commit d69445a

Please sign in to comment.