Skip to content

Commit

Permalink
Revert "Base BreachAlertsManager with loadBreaches() and compareToBre…
Browse files Browse the repository at this point in the history
…aches() (#6696)"

This reverts commit 6110fd0.
  • Loading branch information
vphong authored May 26, 2020
1 parent 6110fd0 commit c14df76
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 166 deletions.
4 changes: 0 additions & 4 deletions Client.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@
C8F457AA1F1FDD9B000CB895 /* BrowserViewController+KeyCommands.swift in Sources */ = {isa = PBXBuildFile; fileRef = C8F457A91F1FDD9B000CB895 /* BrowserViewController+KeyCommands.swift */; };
C8FB0C75232151BA00031088 /* AppMenu.swift in Sources */ = {isa = PBXBuildFile; fileRef = C8FB0C74232151BA00031088 /* AppMenu.swift */; };
C8FB0C782321523D00031088 /* PageActionMenu.swift in Sources */ = {isa = PBXBuildFile; fileRef = C8FB0C772321523D00031088 /* PageActionMenu.swift */; };
CA77ABFD24773C92005079F9 /* BreachAlertsManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = CA77ABF424772D98005079F9 /* BreachAlertsManager.swift */; };
CDB3BE8724746787009320EE /* FirefoxAccountSignInViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDB3BE8624746787009320EE /* FirefoxAccountSignInViewController.swift */; };
CE7F11941F3CEEC800ABFC0B /* RemoteDevices.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE7F115E1F3CCEF900ABFC0B /* RemoteDevices.swift */; };
CEFA977E1FAA6B490016F365 /* SyncContentSettingsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = CEFA977D1FAA6B490016F365 /* SyncContentSettingsViewController.swift */; };
Expand Down Expand Up @@ -1502,7 +1501,6 @@
C8F457A91F1FDD9B000CB895 /* BrowserViewController+KeyCommands.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "BrowserViewController+KeyCommands.swift"; sourceTree = "<group>"; };
C8FB0C74232151BA00031088 /* AppMenu.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppMenu.swift; sourceTree = "<group>"; };
C8FB0C772321523D00031088 /* PageActionMenu.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PageActionMenu.swift; sourceTree = "<group>"; };
CA77ABF424772D98005079F9 /* BreachAlertsManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BreachAlertsManager.swift; sourceTree = "<group>"; };
CDB3BE8624746787009320EE /* FirefoxAccountSignInViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FirefoxAccountSignInViewController.swift; sourceTree = "<group>"; };
CE7F115E1F3CCEF900ABFC0B /* RemoteDevices.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RemoteDevices.swift; sourceTree = "<group>"; };
CEFA977D1FAA6B490016F365 /* SyncContentSettingsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SyncContentSettingsViewController.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -3127,7 +3125,6 @@
E63ED7D71BFCD9990097D08E /* LoginTableViewCell.swift */,
E63ED8E01BFD25580097D08E /* LoginListViewController.swift */,
E633E2D91C21EAF8001FFF6C /* LoginDetailViewController.swift */,
CA77ABF424772D98005079F9 /* BreachAlertsManager.swift */,
);
path = "Login Management";
sourceTree = "<group>";
Expand Down Expand Up @@ -5175,7 +5172,6 @@
7BA0601B1C0F4DE200DFADB6 /* TabPeekViewController.swift in Sources */,
6669B5E2211418A200CA117B /* WebsiteDataSearchResultsViewController.swift in Sources */,
E6D8D5E71B569D70009E5A58 /* BrowserTrayAnimators.swift in Sources */,
CA77ABFD24773C92005079F9 /* BreachAlertsManager.swift in Sources */,
EBC4869E2195F58300CDA48D /* AboutHomeHandler.swift in Sources */,
DDA24A431FD84D630098F159 /* DefaultSearchPrefs.swift in Sources */,
E65075611E37F77D006961AC /* MenuHelper.swift in Sources */,
Expand Down
155 changes: 0 additions & 155 deletions Client/Frontend/Login Management/BreachAlertsManager.swift

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ private extension UITableView {
private let CellReuseIdentifier = "cell-reuse-id"
private let SectionHeaderId = "section-header-id"
private let LoginsSettingsSection = 0
private let breachAlertsManager = BreachAlertsManager()

class LoginListViewController: SensitiveViewController {

Expand Down Expand Up @@ -251,12 +250,6 @@ class LoginListViewController: SensitiveViewController {
let deferred = Deferred<Maybe<[LoginRecord]>>()
profile.logins.searchLoginsWithQuery(query) >>== { logins in
deferred.fillIfUnfilled(Maybe(success: logins.asArray()))

// consider taking logins to breachalertsmanager from here
// which indexes need a special layout? to display breached login
breachAlertsManager.loadBreaches()
breachAlertsManager.compareToBreaches(logins.asArray())

succeed()
}
return deferred
Expand Down

0 comments on commit c14df76

Please sign in to comment.