Login storage refactor.

[grigoryk]

Companion PR for mozilla-mobile/android-components#6128

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[csadilek]

👍

[grigoryk]

Just waiting for mozilla-mobile/android-components#6128 to be available in a snapshot (triggered, progress in https://firefox-ci-tc.services.mozilla.com/tasks/groups/fXhTXbmHT7WjMLCYInkwyA)

[pocmo]

Snapshots are ready. Let's rerun this. :)

[pocmo]

This looks like it needs a rebase on top of master to address some other changes that have happened since opening the PR. I'll do that now.

[pocmo]

I still see some other failures locally:

e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt: (332, 21): No value passed for parameter 'keyStore'
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt: (32, 47): Unresolved reference: SyncableLoginsStorage
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt: (53, 23): Unresolved reference: SyncableLoginsStorage
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt: (40, 47): Unresolved reference: SyncableLoginsStorage
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt: (76, 71): No value passed for parameter 'securePreferences'
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt: (88, 71): No value passed for parameter 'securePreferences'
e: /Users/sebastiankaspari/Projects/Mozilla/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt: (195, 36): Unresolved reference: SyncableLoginsStorage

[pocmo]

Ah, I think this PR only contains the changes for the beta flavor. I'll adapt it and add the changes for the nightly flavor to it.

[pocmo]

Build passes, but tests not yet... looking. :)

[pocmo]

... and ktlint.

[codecov-io]

Codecov Report

Merging #8875 into master will increase coverage by 0.04%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##             master   #8875      +/-   ##
===========================================
+ Coverage     18.95%     19%   +0.04%     
  Complexity      500     500              
===========================================
  Files           327     327              
  Lines         13007   12991      -16     
  Branches       1720    1720              
===========================================
+ Hits           2466    2469       +3     
+ Misses        10332   10313      -19     
  Partials        209     209

Impacted Files	Coverage Δ	Complexity Δ
...in/java/org/mozilla/fenix/components/Components.kt	36.36% <0%> (+0.8%)	1 <0> (ø)	⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...enix/settings/logins/SavedLoginSiteInfoFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...zilla/fenix/settings/logins/SavedLoginsFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...org/mozilla/fenix/components/BackgroundServices.kt	21.25% <0%> (+0.26%)	0 <0> (ø)	⬇️
...src/main/java/org/mozilla/fenix/components/Core.kt	20.87% <50%> (+1.83%)	1 <0> (ø)	⬇️
.../fenix/collections/CollectionCreationInteractor.kt	8.33% <0%> (-2.78%)	0% <0%> (ø)
...nix/components/toolbar/BrowserToolbarController.kt	64.53% <0%> (+2.32%)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a75d82...537390d. Read the comment docs.

[pocmo]

Alright, green, phew. Lets get this in to unblock master.