Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8324 - Only use encrypted storage for Nightly/Debug populations. #8446

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Feb 15, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager changed the title For #8324 - Only use encrypted storage for Nightly/Debug populations For #8324 - Only use encrypted storage for Nightly/Debug populations. Feb 16, 2020
context = context,
name = KEY_STORAGE_NAME,
forceInsecure = !Config.channel.isNightlyOrDebug
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen to release users that have been using this before? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the features using secure storage were only enabled in Nightly (just Logins).
I have also added a check that attempts to migrate data from the other store (but won't crash if we can't access the keystore)
mozilla-mobile/android-components#5902

@boek boek merged commit f52f87f into mozilla-mobile:master Feb 18, 2020
@ekager ekager deleted the 8324-secure branch February 19, 2020 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants