For #6758 - Add Top Sites to Fenix

[gabrielluong]

Fixes #6757, #6758 , #6759, #7525

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[codecov-io]

Codecov Report

Merging #7523 into master will increase coverage by 0.32%.
The diff coverage is 14.58%.

@@             Coverage Diff              @@
##             master    #7523      +/-   ##
============================================
+ Coverage     19.24%   19.56%   +0.32%     
- Complexity      451      469      +18     
============================================
  Files           301      304       +3     
  Lines         11670    11658      -12     
  Branches       1584     1576       -8     
============================================
+ Hits           2246     2281      +35     
+ Misses         9239     9198      -41     
+ Partials        185      179       -6

Impacted Files	Coverage Δ	Complexity Δ
...fenix/home/sessioncontrol/SessionControlAdapter.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...me/sessioncontrol/viewholders/TopSiteViewHolder.kt	0% <0%> (ø)	0 <0> (?)
...ioncontrol/viewholders/topsites/TopSitesAdapter.kt	0% <0%> (ø)	0 <0> (?)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt	21.37% <0%> (-0.72%)	0 <0> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt	7.34% <0%> (-0.72%)	3 <0> (ø)
...ava/org/mozilla/fenix/components/TopSiteStorage.kt	0% <0%> (ø)	0 <0> (?)
...trol/viewholders/topsites/TopSiteItemViewHolder.kt	0% <0%> (ø)	0 <0> (?)
... and 81 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa0a84...f923f9c. Read the comment docs.

[gabrielluong]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How often the user interact with top sites.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• This will help us prioritize bugs and features related to top sites based on user need.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• No current alternative methods.

4. Can current instrumentation answer these questions?

• Currently there are no events to track this.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

• Until 03/01/2020

7. What populations will you measure?

• All release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[boek]

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, metrics.yaml and metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, under data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Has expiry

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Type 2

5. Is the data collection request for default-on or default-off?
   Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does there need to be a check-in in the future to determine whether to renew the data?
   Will check-in at expiry

9. Does the data collection use a third-party collection tool?
   No

[gabrielluong]

Rebased

[boek]

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, metrics.yaml and metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, under data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Has expiry

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Type 2

5. Is the data collection request for default-on or default-off?
   Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does there need to be a check-in in the future to determine whether to renew the data?
   Will check-in at expiry

9. Does the data collection use a third-party collection tool?
   No

Nits were fixed

[Cheap-Skate]

Hi, I have been playing with the test build. I like it. Main comment is the text underneath the Top Sites favicons is very small. Could it be any larger? Thanks.

[gabrielluong]

Hi, I have been playing with the test build. I like it. Main comment is the text underneath the Top Sites favicons is very small. Could it be any larger? Thanks.

Totally understand this. We will definitely be polishing this feature, but expect this as a follow up.

[Cheap-Skate]

Thanks. Looking forward to it landing, big step forward IMHO.