Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #3756 - Mark HTTP sites insecure #4689

Closed
wants to merge 1 commit into from
Closed

Issue #3756 - Mark HTTP sites insecure #4689

wants to merge 1 commit into from

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Aug 12, 2019 •
edited
Loading

Screenshot_20190814-110437

Changes the HTTP indicator to a broken padlock.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@NotWoods NotWoods marked this pull request as ready for review August 13, 2019 20:29
@NotWoods NotWoods requested a review from a team as a code owner August 13, 2019 20:29
@NotWoods
Copy link
Contributor Author

@AmyYLee reviewed the icon and sent over a single colour version to use instead.

@NotWoods
Copy link
Contributor Author

We've decided to update BrowserToolbar's default instead, so Fenix doesn't need to change its code at all now.

@NotWoods NotWoods closed this Aug 14, 2019
@NotWoods
Copy link
Contributor Author

mozilla-mobile/android-components#4127 replaces this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotWoods @pocmo