For #2395 - Properly takes you back to where you start authenticationon completion #3153

boek · 2019-06-04T22:57:57Z

Pull Request checklist

Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

app/src/main/java/org/mozilla/fenix/components/features/FirefoxAccountsAuthFeature.kt

app/src/main/java/org/mozilla/fenix/settings/TurnOnSyncFragment.kt

…authentication on completion

colintheshots · 2019-06-05T17:02:10Z

/bitrise/src/app/src/main/java/org/mozilla/fenix/components/features/FirefoxAccountsAuthFeature.kt:14:1: Needless blank line(s)

…s why we copy a feature

boek requested a review from a team as a code owner June 4, 2019 22:57

colintheshots reviewed Jun 5, 2019

View reviewed changes

app/src/main/java/org/mozilla/fenix/components/features/FirefoxAccountsAuthFeature.kt Outdated Show resolved Hide resolved

app/src/main/java/org/mozilla/fenix/settings/TurnOnSyncFragment.kt Show resolved Hide resolved

boek mentioned this pull request Jun 5, 2019

Improve interface to create a FirefoxAccountsAuthFeature mozilla-mobile/android-components#3272

Closed

boek added 2 commits June 5, 2019 09:52

For mozilla-mobile#2395 - Properly takes you back to where you start …

495fb8f

…authentication on completion

For mozilla-mobile#2395 - Fixes test suite

a6eadab

boek force-pushed the i2395 branch from 876f5c2 to 31bc8f8 Compare June 5, 2019 16:52

colintheshots approved these changes Jun 5, 2019

View reviewed changes

For mozilla-mobile#2395 - Adds an early return statement and document…

612106b

…s why we copy a feature

boek force-pushed the i2395 branch from 31bc8f8 to 612106b Compare June 5, 2019 17:17

boek merged commit 27fdd96 into mozilla-mobile:master Jun 5, 2019

boek deleted the i2395 branch September 4, 2019 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #2395 - Properly takes you back to where you start authenticationon completion #3153

For #2395 - Properly takes you back to where you start authenticationon completion #3153

boek commented Jun 4, 2019

colintheshots commented Jun 5, 2019 •

edited

Loading

For #2395 - Properly takes you back to where you start authenticationon completion #3153

For #2395 - Properly takes you back to where you start authenticationon completion #3153

Conversation

boek commented Jun 4, 2019

Pull Request checklist

colintheshots commented Jun 5, 2019 • edited Loading

colintheshots commented Jun 5, 2019 •

edited

Loading