Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Close #26320: Make Nimbus first-startup comments clear in FenixApplication #27927

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

jonalmeida
Copy link
Contributor

@jonalmeida jonalmeida commented Nov 21, 2022

Adding a bit of cleanup that makes it clear we don't want anyone to add things to the application onCreate before Nimbus. No logical changes; cleanup.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26320

@jonalmeida jonalmeida added the needs:review PRs that need to be reviewed label Nov 21, 2022
@jonalmeida jonalmeida requested review from a team as code owners November 21, 2022 16:22
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✨

@jonalmeida jonalmeida added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Nov 21, 2022
@jonalmeida
Copy link
Contributor Author

@jhugman added you as a reviewer so you're aware.

@mergify mergify bot merged commit 6d9808a into mozilla-mobile:main Nov 21, 2022
@jonalmeida jonalmeida deleted the issue-26320 branch November 21, 2022 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nimbus initialization should be triggered and complete before first page load starts
2 participants