Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Close #27023: Add capability to override telemetry URL using local properties #27748

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Nov 7, 2022

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27023

@rocketsroger rocketsroger added the needs:review PRs that need to be reviewed label Nov 7, 2022
@rocketsroger rocketsroger requested review from a team as code owners November 7, 2022 22:37
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local.properties > pref > default?

Let's document this on the README in the localproperties helpers or somewhere else in our docs/ dir (but not wiki).

It's easy to make the mistake that a value is set in local.properties and then try to set a pref value that is not actually used even though it's saved. I'm not sure how you'd like to handle that, so I'll leave it to you to consider and not block this PR for now.

@rocketsroger
Copy link
Contributor Author

local.properties > pref > default?

Let's document this on the README in the localproperties helpers or somewhere else in our docs/ dir (but not wiki).

Sounds good I'll document this in the README.

It's easy to make the mistake that a value is set in local.properties and then try to set a pref value that is not actually used even though it's saved. I'm not sure how you'd like to handle that, so I'll leave it to you to consider and not block this PR for now.

Yes, this is a bit awkward. Let me think if there's a simple way to avoid this. Thanks

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated changes look good to me too, thanks!

@rocketsroger rocketsroger added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Nov 8, 2022
@mergify mergify bot merged commit 5af08cd into mozilla-mobile:main Nov 8, 2022
@rocketsroger rocketsroger deleted the FB_27023 branch November 8, 2022 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability to override telemetry URL
2 participants