Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27671 - Search metrics will now be sent in baseline ping #27672

Merged
merged 2 commits into from
Nov 3, 2022
Merged

For #27671 - Search metrics will now be sent in baseline ping #27672

merged 2 commits into from
Nov 3, 2022

Conversation

perrymcmanis144
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

Tests: this counter is already sent in metrics & is covered by existing tests
Screenshots: no visible changes
Accessibility: does not impact any user facing feature

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

@perrymcmanis144 perrymcmanis144 requested review from a team as code owners November 2, 2022 19:11
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request 
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

Dexterp37
Dexterp37 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

app/metrics.yaml Show resolved Hide resolved
@rocketsroger rocketsroger added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Nov 3, 2022
@mergify mergify bot mentioned this pull request Nov 3, 2022
Closed
4 tasks
@jonalmeida jonalmeida merged commit 90d0d9a into mozilla-mobile:main Nov 3, 2022
@jonalmeida
Copy link
Contributor

Manually rebasing/merging because it will require us do that either way and we're second in queue.

@rocketsroger
Copy link
Contributor

@Mergifyio backport releases_v107.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2022

backport releases_v107.0.0

✅ Backports have been created

@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
rocketsroger pushed a commit that referenced this pull request Nov 3, 2022
@mergify @perrymcmanis144
For #27671 - Search metrics will now be sent in baseline ping (backp…
bbffa55 
…ort #27672) (#27696)

* added search metrics to baseline ping

(cherry picked from commit c4b4f07)

* Update app/metrics.yaml

Co-authored-by: Alessio Placitelli <[email protected]>
(cherry picked from commit 90d0d9a)

Co-authored-by: Perry McManis <[email protected]>
Co-authored-by: perrymcmanis144 <[email protected]>
@rocketsroger
Copy link
Contributor

@perrymcmanis144 Merged to Beta v107

lillabldv added a commit to karmaSearch/fenix that referenced this pull request Dec 13, 2022
@lillabldv
Merge branch 'releases_v107.0.0' into merge/107.1
9d39610 
* releases_v107.0.0: (1269 commits)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 107.0.7.
  For mozilla-mobile#27782: add first URI load growth data
  For 27768: add FirstAppOpenForDay growth data
  For mozilla-mobile#27698: add set as default growth data (mozilla-mobile#27750)
  For mozilla-mobile#27746 - Move top sites text outside of backplating
  Revert "For mozilla-mobile#26606 - Add backplating to Top Sites
  Bug 1798805 - Initialize the FxaPushSupportFeature
  Update to Android-Components 107.0.6.
  Bump version to 107.1.0
  Sync Strings from main to releases_107.0 (mozilla-mobile#27737)
  Sync Strings from main to releases_107.0 (mozilla-mobile#27728)
  Sync Strings from main to releases_107.0 (mozilla-mobile#27718)
  Sync Strings from main to releases_107.0 (mozilla-mobile#27702)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 107.0.5.
  For mozilla-mobile#27671 - Search metrics will now be sent in baseline ping (backport mozilla-mobile#27672) (mozilla-mobile#27696)
  Strings - app/src/main/res/values-sat/strings.xml (mozilla-mobile#27681)
  Sync Strings from main to releases_107.0 (mozilla-mobile#27655)
  For mozilla-mobile#27627 - Check the TCP CFR status lazily
  ...

# Conflicts:
#	app/lint-baseline.xml
#	app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt
#	app/src/main/java/org/mozilla/fenix/BrowserDirection.kt
#	app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
#	app/src/main/java/org/mozilla/fenix/FenixApplication.kt
#	app/src/main/java/org/mozilla/fenix/HomeActivity.kt
#	app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
#	app/src/main/java/org/mozilla/fenix/components/Analytics.kt
#	app/src/main/java/org/mozilla/fenix/components/Components.kt
#	app/src/main/java/org/mozilla/fenix/components/Core.kt
#	app/src/main/java/org/mozilla/fenix/components/appstate/AppAction.kt
#	app/src/main/java/org/mozilla/fenix/components/appstate/AppState.kt
#	app/src/main/java/org/mozilla/fenix/components/appstate/AppStoreReducer.kt
#	app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt
#	app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMenuController.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
#	app/src/main/java/org/mozilla/fenix/compose/SectionHeader.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/CustomAttributeProvider.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/DefaultMessageController.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/Message.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/MessageController.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/MessagingState.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/NimbusMessagingStorage.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/OnDiskMessageMetadataStorage.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/state/MessagingMiddleware.kt
#	app/src/main/java/org/mozilla/fenix/gleanplumb/state/MessagingReducer.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
#	app/src/main/java/org/mozilla/fenix/home/PocketUpdatesMiddleware.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlInteractor.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CustomizeHomeButtonViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/MessageCardViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/home/topsites/TopSitePagerViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt
#	app/src/main/java/org/mozilla/fenix/onboarding/DefaultBrowserNotificationWorker.kt
#	app/src/main/java/org/mozilla/fenix/onboarding/JumpBackInCFRDialog.kt
#	app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt
#	app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
#	app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt
#	app/src/main/java/org/mozilla/fenix/settings/autofill/AutofillSettingFragment.kt
#	app/src/main/java/org/mozilla/fenix/settings/logins/fragment/SavedLoginsAuthFragment.kt
#	app/src/main/java/org/mozilla/fenix/share/ShareInteractor.kt
#	app/src/main/java/org/mozilla/fenix/share/ShareToAccountDevicesView.kt
#	app/src/main/java/org/mozilla/fenix/share/ShareViewModel.kt
#	app/src/main/java/org/mozilla/fenix/share/listadapters/AccountDevicesAdapter.kt
#	app/src/main/java/org/mozilla/fenix/share/viewholders/AccountDeviceViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/FloatingActionButtonBinding.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayMenu.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayStore.kt
#	app/src/main/java/org/mozilla/fenix/utils/Settings.kt
#	app/src/main/java/org/mozilla/fenix/wallpapers/Wallpaper.kt
#	app/src/main/java/org/mozilla/fenix/wallpapers/WallpaperManager.kt
#	app/src/main/res/layout/component_collection_creation.xml
#	app/src/main/res/layout/component_collection_creation_select_collection.xml
#	app/src/main/res/layout/component_tabstray2.xml
#	app/src/main/res/layout/component_tracking_protection_panel.xml
#	app/src/main/res/layout/experiment_default_browser.xml
#	app/src/main/res/layout/fenix_snackbar.xml
#	app/src/main/res/layout/fragment_add_login.xml
#	app/src/main/res/layout/fragment_credit_card_editor.xml
#	app/src/main/res/layout/fragment_edit_login.xml
#	app/src/main/res/layout/fragment_home.xml
#	app/src/main/res/layout/fragment_login_detail.xml
#	app/src/main/res/layout/fragment_pwa_onboarding.xml
#	app/src/main/res/layout/fragment_sign_out.xml
#	app/src/main/res/layout/fragment_tracking_protection_blocking.xml
#	app/src/main/res/layout/history_list_item.xml
#	app/src/main/res/layout/no_collections_message.xml
#	app/src/main/res/layout/onboarding_inactive_tabs_cfr.xml
#	app/src/main/res/layout/onboarding_jump_back_in_cfr.xml
#	app/src/main/res/layout/pbm_shortcut_popup.xml
#	app/src/main/res/layout/search_suggestions_hint.xml
#	app/src/main/res/layout/studies_section_item.xml
#	app/src/main/res/values-ast/strings.xml
#	app/src/main/res/values-be/strings.xml
#	app/src/main/res/values-br/strings.xml
#	app/src/main/res/values-ca/strings.xml
#	app/src/main/res/values-ckb/strings.xml
#	app/src/main/res/values-co/strings.xml
#	app/src/main/res/values-cs/strings.xml
#	app/src/main/res/values-cy/strings.xml
#	app/src/main/res/values-da/strings.xml
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values-dsb/strings.xml
#	app/src/main/res/values-el/strings.xml
#	app/src/main/res/values-en-rCA/strings.xml
#	app/src/main/res/values-en-rGB/strings.xml
#	app/src/main/res/values-eo/strings.xml
#	app/src/main/res/values-es-rAR/strings.xml
#	app/src/main/res/values-es-rCL/strings.xml
#	app/src/main/res/values-es-rES/strings.xml
#	app/src/main/res/values-es-rMX/strings.xml
#	app/src/main/res/values-es/strings.xml
#	app/src/main/res/values-et/strings.xml
#	app/src/main/res/values-eu/strings.xml
#	app/src/main/res/values-fi/strings.xml
#	app/src/main/res/values-fr/strings.xml
#	app/src/main/res/values-fy-rNL/strings.xml
#	app/src/main/res/values-ga-rIE/strings.xml
#	app/src/main/res/values-gn/strings.xml
#	app/src/main/res/values-hsb/strings.xml
#	app/src/main/res/values-hu/strings.xml
#	app/src/main/res/values-hy-rAM/strings.xml
#	app/src/main/res/values-ia/strings.xml
#	app/src/main/res/values-in/strings.xml
#	app/src/main/res/values-is/strings.xml
#	app/src/main/res/values-it/strings.xml
#	app/src/main/res/values-iw/strings.xml
#	app/src/main/res/values-ja/strings.xml
#	app/src/main/res/values-ka/strings.xml
#	app/src/main/res/values-kab/strings.xml
#	app/src/main/res/values-kk/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-lij/strings.xml
#	app/src/main/res/values-lo/strings.xml
#	app/src/main/res/values-my/strings.xml
#	app/src/main/res/values-nb-rNO/strings.xml
#	app/src/main/res/values-nl/strings.xml
#	app/src/main/res/values-nn-rNO/strings.xml
#	app/src/main/res/values-oc/strings.xml
#	app/src/main/res/values-pa-rIN/strings.xml
#	app/src/main/res/values-pl/strings.xml
#	app/src/main/res/values-pt-rBR/strings.xml
#	app/src/main/res/values-pt-rPT/strings.xml
#	app/src/main/res/values-rm/strings.xml
#	app/src/main/res/values-ro/strings.xml
#	app/src/main/res/values-ru/strings.xml
#	app/src/main/res/values-sat/strings.xml
#	app/src/main/res/values-sk/strings.xml
#	app/src/main/res/values-sl/strings.xml
#	app/src/main/res/values-sq/strings.xml
#	app/src/main/res/values-su/strings.xml
#	app/src/main/res/values-sv-rSE/strings.xml
#	app/src/main/res/values-szl/strings.xml
#	app/src/main/res/values-ta/strings.xml
#	app/src/main/res/values-tg/strings.xml
#	app/src/main/res/values-th/strings.xml
#	app/src/main/res/values-tok/strings.xml
#	app/src/main/res/values-tr/strings.xml
#	app/src/main/res/values-trs/strings.xml
#	app/src/main/res/values-uk/strings.xml
#	app/src/main/res/values-vi/strings.xml
#	app/src/main/res/values-zh-rCN/mozonline_strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
#	app/src/main/res/values-zh-rTW/strings.xml
#	app/src/main/res/values/dimens.xml
#	app/src/main/res/values/mozonline_strings.xml
#	app/src/main/res/values/preference_keys.xml
#	app/src/main/res/values/static_strings.xml
#	app/src/main/res/values/strings.xml
#	app/src/main/res/values/styles.xml
#	app/src/main/res/xml/preferences.xml
#	app/src/main/res/xml/preferences_default_browser_experiment.xml
#	app/src/test/java/org/mozilla/fenix/components/AppStoreTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/DefaultMessageControllerTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/MessagingFeatureTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/NimbusMessagingStorageTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/OnDiskMessageMetadataStorageTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/state/MessagingMiddlewareTest.kt
#	app/src/test/java/org/mozilla/fenix/gleanplumb/state/MessagingReducerTest.kt
#	app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt
#	app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/recentvisits/interactor/RecentVisitsInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/sessioncontrol/SessionControlViewTest.kt
#	app/src/test/java/org/mozilla/fenix/share/ShareViewModelTest.kt
#	app/src/test/java/org/mozilla/fenix/share/viewholders/AccountDeviceViewHolderTest.kt
#	app/src/test/java/org/mozilla/fenix/share/viewholders/AppViewHolderTest.kt
#	app/src/test/java/org/mozilla/fenix/wallpapers/WallpaperManagerTest.kt
#	buildSrc/src/main/java/AndroidComponents.kt
#	nimbus.fml.yaml
#	version.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perrymcmanis144 @jonalmeida @rocketsroger @Dexterp37