This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #26424 - Handle special legacy wallpaper cases #27137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewTighe
approved these changes
Sep 23, 2022
| if (settings.shouldMigrateLegacyWallpaper) { | ||
| migrationHelper.migrateLegacyWallpaper(currentWallpaperName) | ||
| migrationHelper.migrateLegacyWallpaper(settings.currentWallpaperName) |
There was a problem hiding this comment.
I think we could move this second (settings.shouldMigrateLegacyWallpaper) into the first one.
Comment on lines
107
to
112
| internal fun getMigratedWallpaperName(wallpaperName: String) = | ||
| if (wallpaperName == beachVibeName) { | ||
| "beach-vibes" | ||
| } else { | ||
| wallpaperName | ||
| } |
There was a problem hiding this comment.
I believe we will also want to update settings with the new name.
| @@ -29,6 +35,21 @@ class LegacyWallpaperMigration( | |||
| suspend fun migrateLegacyWallpaper( | |||
There was a problem hiding this comment.
We could potentially update this function to return the migrated (or the same, if unchanged) name instead of splitting the behavior into two functions.
Alexandru2909
force-pushed
the
26424_2
branch
from
fa82f68 to
7a4a5b0
Compare
Alexandru2909
force-pushed
the
26424_2
branch
from
7a4a5b0 to
742fb80
Compare
|
Latest updates look good! Please land when able, we will want to uplift this for 106 |
Alexandru2909
added
the
pr:needs-landing
|
@mergify backport releases_v106.0.0 |
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle special cases for drawable legacy wallpapers and "beach-vibe" wallpaper which is named "beach-vibes" in V2, according to comment.
Videos of upgrading from 105 to 106:
device-2022-09-23-180025.mp4
device-2022-09-23-171746.mp4
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-debugtask.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Fixes #26424