Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #26489 - Add synced tab pickup onboarding message #26507

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

sarah541
Copy link
Contributor

@sarah541 sarah541 commented Aug 17, 2022

Screenshot_20220826-155655

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26489

@sarah541
Copy link
Contributor Author

DATA REVIEW REQUEST

  1. What questions will you answer with this data?

This data will help us understand how users interact with the Synced Tab Contextual Feature Recommendation Popup.

  1. Why does Mozilla need to answer these questions? Are there benefits for users?
    Do we need this information to address product or business requirements?

To better understand the usefulness of new features.

  1. What alternative methods did you consider to answer these questions?
    Why were they not sufficient?

There are no other.

  1. Can current instrumentation answer these questions?

No.

  1. List all proposed measurements and indicate the category of data collection for each
    measurement, using the Firefox data collection categories found on the Mozilla wiki.
Measurement Name Measurement Description Data Collection Category Tracking Bug
onboarding.syn_cfr_shown The Synced Tab Onboarding CFR was shown to the user. Category 2 - interaction #26489
onboarding.sync_cfr_implicit_dismissal The Synced Tab Onboarding CFR was dismissed by the user by interacting with the outside of the popup. Category 2 - interaction #26489
onboarding.sync_cfr_explicit_dismissal The Synced Tab Onboarding CFR was dismissed by the user by clicking on the "X" button to close the popup. Category 2 - interaction #26489
  1. Please provide a link to the documentation for this data collection which
    describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented
in the Glean Dictionary.

  1. How long will this data be collected?

Up until version '119', with the option to renew at that point.

  1. What populations will you measure?

All channels, countries, and locales. No filters.

  1. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

  1. Please provide a general description of how you will analyze this data.

Glean and Amplitude.


  1. Where do you intend to share the results of your analysis?

Only on Glean, Amplitude, and with mobile teams.


  1. Is there a third-party tool (i.e. not Glean or Telemetry) that you
    are proposing to use for this data collection?

No.

@rocketsroger
Copy link
Contributor

DATA REVIEW REQUEST

1. What questions will you answer with this data?

This data will help us understand how users interact with the Synced Tab Contextual Feature Recommendation Popup.

2. Why does Mozilla need to answer these questions? Are there benefits for users?Do we need this information to address product or business requirements?

To better understand the usefulness of new features.

3. What alternative methods did you consider to answer these questions?Why were they not sufficient?

There are no other.

4. Can current instrumentation answer these questions?

No.

5. List all proposed measurements and indicate the category of data collection for eachmeasurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Name Measurement Description Data Collection Category Tracking Bug
onboarding.syn_cfr_shown The Synced Tab Onboarding CFR was shown to the user. Category 2 - interaction #26489
onboarding.sync_cfr_implicit_dismissal The Synced Tab Onboarding CFR was dismissed by the user by interacting with the outside of the popup. Category 2 - interaction #26489
onboarding.sync_cfr_explicit_dismissal The Synced Tab Onboarding CFR was dismissed by the user by clicking on the "X" button to close the popup. Category 2 - interaction #26489

6. Please provide a link to the documentation for this data collection whichdescribes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documentedin the Glean Dictionary.

7. How long will this data be collected?

Up until version '119', with the option to renew at that point.

8. What populations will you measure?

All channels, countries, and locales. No filters.

9. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

10. Please provide a general description of how you will analyze this data.

Glean and Amplitude.


11. Where do you intend to share the results of your analysis?

Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Glean or Telemetry) that youare proposing to use for this data collection?

No.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end or be renewed by version 119

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger rocketsroger removed their request for review August 17, 2022 14:58
@sarah541
Copy link
Contributor Author

sarah541 commented Aug 17, 2022

Do not land until #26203 this be merged since merging current one could cause showing Jump Back In and Synced Tabs CFR simultaneously which we do no want.

cc : @Alexandru2909

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Aug 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2022

This pull request has conflicts when rebasing. Could you fix it @sarah541? 🙏

@sarah541 sarah541 added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:approved PR that has been approved labels Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synced Tab Pickup Onboarding Message
4 participants