-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #26489 - Add synced tab pickup onboarding message #26507
Conversation
DATA REVIEW REQUEST
This data will help us understand how users interact with the Synced Tab Contextual Feature Recommendation Popup.
To better understand the usefulness of new features.
There are no other.
No.
This collection is Glean so is documented
Up until version '119', with the option to renew at that point.
All channels, countries, and locales. No filters.
These collections are Glean. The opt-out can be found in the product's preferences.
Glean and Amplitude.
Only on Glean, Amplitude, and with mobile teams.
No. |
Data Review
Yes, through the metrics.yaml file and the Glean Dictionary
Yes, through the "Send Usage Data" preference in the application settings
N/A, collection set to end or be renewed by version 119
Category 2, Interaction data
default-on
No
Yes
No Resultdata-review+ |
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/onboarding/SyncCFRPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
Show resolved
Hide resolved
Do not land until #26203 this be merged since merging current one could cause showing Jump Back In and Synced Tabs CFR simultaneously which we do no want. cc : @Alexandru2909 |
app/src/main/java/org/mozilla/fenix/onboarding/SyncCFRPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/onboarding/SyncCFRPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/onboarding/SyncCFRPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/onboarding/SyncCFRPresenter.kt
Outdated
Show resolved
Hide resolved
This pull request has conflicts when rebasing. Could you fix it @sarah541? 🙏 |
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #26489