Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #23431 - Display the order of Contile Top Sites correctly #23656

Merged
merged 2 commits into from
Feb 10, 2022
Merged

For #23431 - Display the order of Contile Top Sites correctly #23656

merged 2 commits into from
Feb 10, 2022

Conversation

gabrielluong
Copy link
Member

Fixes #23431. This also fixes the breaking change introduced from mozilla-mobile/android-components#11654.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested review from a team as code owners February 9, 2022 18:08
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Feb 9, 2022
MozillaNoah
MozillaNoah approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielluong gabrielluong removed the request for review from Amejia481 February 9, 2022 18:35
@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Feb 9, 2022
@gabrielluong gabrielluong force-pushed the 23431 branch 2 times, most recently from 10f503b to 45676d1 Compare February 9, 2022 21:25
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2022

This pull request has conflicts when rebasing. Could you fix it @gabrielluong? 🙏

@mergify mergify bot merged commit 37a0edc into mozilla-mobile:main Feb 10, 2022
@gabrielluong gabrielluong deleted the 23431 branch February 10, 2022 01:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display the order of Contile Top Sites correctly
2 participants
@gabrielluong @MozillaNoah